From: Nathan Wharton <naw@greptar.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] [batman] Align pointers in hna list elements
Date: Tue, 2 Jun 2009 13:56:03 -0500 [thread overview]
Message-ID: <4313f3060906021156r1920d42bp632d49bd0c37173e@mail.gmail.com> (raw)
In-Reply-To: <1243965365-6526-1-git-send-email-sven.eckelmann@gmx.de>
On Tue, Jun 2, 2009 at 12:56 PM, Sven Eckelmann <sven.eckelmann@gmx.de> wrote:
> Architectures like SuperARM or Xscale needs aligned data for multi-byte
> operations. GCC can create instructions sequences for packed data, but
> must know that something will not be aligned. Since list_add will
> operate on untyped data over void-pointers it cannot know that
> hna_global_entry is packed and will create only a fast and unsafe
> version for load and store operations.
> It is only important for the first 5 bytes of hna_global_entry to be
> packed we can force these elements to be aligned without changing
> the relative addresses of the first bytes.
>
It looks good here. I am running this combined with the previous 3
patches with cpu/alignment set to bus error on problems.
next prev parent reply other threads:[~2009-06-02 18:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 14:27 [B.A.T.M.A.N.] Kernel crashes with batgat installed Nathan Wharton
2009-05-19 19:21 ` Sven Eckelmann
2009-05-19 20:38 ` Nathan Wharton
2009-05-20 1:30 ` Marek Lindner
2009-05-20 14:34 ` Nathan Wharton
2009-05-20 16:10 ` Marek Lindner
2009-05-20 17:01 ` Nathan Wharton
2009-05-20 19:02 ` Marek Lindner
2009-05-20 19:39 ` Nathan Wharton
2009-05-28 10:40 ` [B.A.T.M.A.N.] [PATCH] [batman] Add padding around allocation debugger structures Sven Eckelmann
2009-05-29 7:02 ` Marek Lindner
2009-05-29 14:00 ` Nathan Wharton
2009-06-01 16:44 ` Sven Eckelmann
2009-06-01 18:03 ` Nathan Wharton
2009-06-01 19:35 ` Sven Eckelmann
2009-06-01 21:50 ` Nathan Wharton
2009-06-02 4:36 ` Marek Lindner
2009-06-02 17:50 ` [B.A.T.M.A.N.] " Sven Eckelmann
2009-06-02 17:56 ` [B.A.T.M.A.N.] [PATCH] [batman] Align pointers in hna list elements Sven Eckelmann
2009-06-02 18:56 ` Nathan Wharton [this message]
2009-06-03 10:39 ` [B.A.T.M.A.N.] [PATCHv2] " Sven Eckelmann
2009-06-03 11:16 ` Marek Lindner
2009-05-28 11:36 ` [B.A.T.M.A.N.] [PATCH 2/3] [batman] Make TYPE_OF_WORD the largest integral type Sven Eckelmann
2009-05-28 11:36 ` [B.A.T.M.A.N.] [PATCH 3/3] [batman] Word-Align char buffer which are later casted to larger data types Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4313f3060906021156r1920d42bp632d49bd0c37173e@mail.gmail.com \
--to=naw@greptar.com \
--cc=b.a.t.m.a.n@open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).