From: Antonio Quartulli <antonio@meshcoding.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"b.a.t.m.a.n@lists.open-mesh.org"
<b.a.t.m.a.n@lists.open-mesh.org>,
Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: fix kernel crash due to missing NULL checks
Date: Tue, 11 Aug 2015 18:42:45 +0200 [thread overview]
Message-ID: <55CA2605.1070201@meshcoding.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CB737B7@AcuExch.aculab.com>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On 05/08/15 15:15, David Laight wrote:
> So is this test just hiding anoter bug somewhere??
Hi David and thanks for your feedback.
The point is that we got several bug reports of kernel crashes due to
NULL pointer deferences in these lines and fter having debugged this
problem for quite a while we preferred to move on and propose this patch.
Still, I am personally debugging this part of the code to understand if
we really have something wrong or if this NULL pointer is something we
should expect (and therefore check).
For the time being we think this patch is better than having horrible
kernel crashes, but I hope to come to a definitive conclusion soon.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-11 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 12:51 [B.A.T.M.A.N.] pull request [net]: batman-adv fixes 20150805 Antonio Quartulli
2015-08-05 12:51 ` [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: avoid DAT to mess up LAN state Antonio Quartulli
2015-08-05 12:51 ` [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: fix kernel crash due to missing NULL checks Antonio Quartulli
2015-08-05 13:15 ` David Laight
2015-08-11 16:42 ` Antonio Quartulli [this message]
2015-08-12 8:44 ` David Laight
2015-08-05 12:51 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: protect tt_local_entry from concurrent delete events Antonio Quartulli
2015-08-05 12:51 ` [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: initialize up/down values when adding a gateway Antonio Quartulli
2015-08-07 22:51 ` [B.A.T.M.A.N.] pull request [net]: batman-adv fixes 20150805 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CA2605.1070201@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=David.Laight@ACULAB.COM \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).