From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Kyungrok Chung <acadx0@gmail.com>,
Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
Antonio Quartulli <a@unstable.cc>,
Sven Eckelmann <sven@narfation.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>
Cc: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH v3 net-next] net: make use of helper netif_is_bridge_master()
Date: Sat, 16 Oct 2021 14:56:00 +0300 [thread overview]
Message-ID: <75a38832-b638-a95a-7ba7-f144cd05d978@nvidia.com> (raw)
In-Reply-To: <20211016112137.18858-1-acadx0@gmail.com>
On 16/10/2021 14:21, Kyungrok Chung wrote:
> Make use of netdev helper functions to improve code readability.
> Replace 'dev->priv_flags & IFF_EBRIDGE' with netif_is_bridge_master(dev).
>
> Signed-off-by: Kyungrok Chung <acadx0@gmail.com>
> ---
>
> v1->v2:
> - Apply fixes to batman-adv, core too.
>
> v2->v3:
> - Fix wrong logic.
>
> net/batman-adv/multicast.c | 2 +-
> net/bridge/br.c | 4 ++--
> net/bridge/br_fdb.c | 6 +++---
> net/bridge/br_if.c | 2 +-
> net/bridge/br_ioctl.c | 2 +-
> net/bridge/br_mdb.c | 4 ++--
> net/bridge/br_netfilter_hooks.c | 2 +-
> net/bridge/br_netlink.c | 4 ++--
> net/core/rtnetlink.c | 2 +-
> 9 files changed, 14 insertions(+), 14 deletions(-)
>
LGTM,
Reviewed-by: Nikolay Aleksandrov <nikolay@nvidia.com>
next prev parent reply other threads:[~2021-10-16 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 11:21 [PATCH v3 net-next] net: make use of helper netif_is_bridge_master() Kyungrok Chung
2021-10-16 11:56 ` Nikolay Aleksandrov [this message]
2021-10-18 12:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75a38832-b638-a95a-7ba7-f144cd05d978@nvidia.com \
--to=nikolay@nvidia.com \
--cc=a@unstable.cc \
--cc=acadx0@gmail.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=roopa@nvidia.com \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).