From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
Sven Eckelmann <sven@narfation.org>
Cc: Andre Kasper <Andre.Kasper@gmx.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses
Date: Sat, 14 Apr 2018 10:34:42 +0800 [thread overview]
Message-ID: <78ec0422-9046-3db1-6a81-4c1c7d0c9968@unstable.cc> (raw)
In-Reply-To: <20180413181618.24144-1-sven@narfation.org>
[-- Attachment #1.1: Type: text/plain, Size: 875 bytes --]
On 14/04/18 02:16, Sven Eckelmann wrote:
> The IP translation layer is using the neighbor table of the kernel to get
> the unicast link layer (mac) address for IP(v4|v6) addresses. The kernel
> can not only return unicast mac addresses to such an RTM_GETNEIGH request
> but also zero mac address. Such an address must be considered invalid
> because the global translation table may not only contain a unique client
> mac address entry for it. The translation from client mac to originator
> will therefore most likely return an unexpected originator.
>
We already handle the case of multiple originators handling the same MAC
address, no? In that case I think we pick the "best" originator.
This case sounds more like a validity check because "a zero MAC should
not be in the translation table", or am I wrong?
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-14 2:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 18:16 [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses Sven Eckelmann
2018-04-14 2:34 ` Antonio Quartulli [this message]
2018-04-14 7:10 ` Sven Eckelmann
2018-04-14 8:11 ` Antonio Quartulli
2018-04-14 9:20 ` Sven Eckelmann
2018-04-14 9:35 ` Antonio Quartulli
2018-04-14 9:36 ` Antonio Quartulli
2018-04-17 8:35 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78ec0422-9046-3db1-6a81-4c1c7d0c9968@unstable.cc \
--to=a@unstable.cc \
--cc=Andre.Kasper@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).