From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from diktynna.open-mesh.org (diktynna.open-mesh.org [136.243.236.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C1A5C61DA4 for ; Fri, 3 Feb 2023 09:38:43 +0000 (UTC) Received: from diktynna.open-mesh.org (localhost [IPv6:::1]) by diktynna.open-mesh.org (Postfix) with ESMTP id 3A68883E92 for ; Fri, 3 Feb 2023 10:38:41 +0100 (CET) Received: from dvalin.narfation.org (dvalin.narfation.org [213.160.73.56]) by diktynna.open-mesh.org (Postfix) with ESMTPS id 53B52800F4 for ; Fri, 3 Feb 2023 10:38:17 +0100 (CET) ARC-Seal: i=1; s=20121; d=open-mesh.org; t=1675417097; a=rsa-sha256; cv=none; b=Nentehna6eNeBzVg5eYnN9+eU9NWxl68gcilA+QARVBL4F+QJQkTlQp2NkL8c4ub1RqByB 95jesaNL+vruZBR1/Jm5Xq93TjOD27d9ixzhfd1XkbNI98xFF8Et6Md7qZJtjPkS80jfb8 XexNloL/ZALnqn7S35VO17YWfLyWXoM= ARC-Authentication-Results: i=1; diktynna.open-mesh.org; dkim=pass header.d=narfation.org header.s=20121 header.b=RyV0pIRW; spf=pass (diktynna.open-mesh.org: domain of sven@narfation.org designates 213.160.73.56 as permitted sender) smtp.mailfrom=sven@narfation.org; dmarc=pass (policy=none) header.from=narfation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1675417097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wIbm+ky4JhJJx9adjLm/JS7p8oau1jmqkNdtBhx/1og=; b=X6310T06ZXomwph2hGciPmkbBaWE9uCRAbSwG3/ldBmrg6GDlzh/bzdu2755kiOwQxA67G EOkKoJcQB6YGNg4TPvF1dwOpAw7Cn7E4LbuxhyDSJ6KXbjXFIrFgpRsnBXHNtg5Mk18zS6 03svfv2GxtSviP3D4mdVO9VpQr72ETw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1675417096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wIbm+ky4JhJJx9adjLm/JS7p8oau1jmqkNdtBhx/1og=; b=RyV0pIRW5IGaHV3JSgOc2pW0zCg/zevuWS1glLXZjxDlMLMHzrfdoqDUt4CcOWfYzM8Vam 0aRnhzKPLYDZt61eCaSEqasvCL5uUJk0FR0fbmgqO/qMYCMhPHOoe0oNwj2DtAKHHTA4um XkifqrFb8fWqe1h85USEo2Z/iVR+PBE= From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org, Jiri Pirko Subject: Re: [PATCH 1/5] batman-adv: Start new development cycle Date: Fri, 03 Feb 2023 10:38:07 +0100 Message-ID: <8520325.EvYhyI6sBW@ripper> In-Reply-To: References: <20230127102133.700173-1-sw@simonwunderlich.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4755678.kQq0lBPeGt"; micalg="pgp-sha512"; protocol="application/pgp-signature" Message-ID-Hash: YOQGIMHSXTUSNBW5SPRX5BIFTK5GOOY6 X-Message-ID-Hash: YOQGIMHSXTUSNBW5SPRX5BIFTK5GOOY6 X-MailFrom: sven@narfation.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-b.a.t.m.a.n.lists.open-mesh.org-0; header-match-b.a.t.m.a.n.lists.open-mesh.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org X-Mailman-Version: 3.2.1 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --nextPart4755678.kQq0lBPeGt Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org, Jiri Pirko Subject: Re: [PATCH 1/5] batman-adv: Start new development cycle Date: Fri, 03 Feb 2023 10:38:07 +0100 Message-ID: <8520325.EvYhyI6sBW@ripper> In-Reply-To: MIME-Version: 1.0 On Friday, 3 February 2023 09:29:50 CET Jiri Pirko wrote: [...] > Why kernel version is not enough for you? My point is, why to maintain > internal driver version alongside with the kernel version? [...] > >Also note that we can't do a simple kernel version to year > >notation mapping in userspace in batctl. OpenWrt uses the most > >recent Linux LTS release. But might feature a backport of a more > >recent batman-adv which is newer than the one this stable kernel > >would provide. Or people also often use Debian stable but compile > >and use the latest batman-adv version with it. > > Yeah, for out of tree driver, have whatever. A while back, my personal opinion changed after there were various Linux developers/maintainers were trying to either remove it or wondering about this bump. The idea which I've proposed was to: * still ship the "backports" like out-of-tree tarball with a module version - but directly in its "compat" code * continue to use in projects (which for whatever reason cannot use the in- kernel implementation) a version which represents their upstream backports tarball + their (patch) revision: Something like "2022.0-openwrt-7" * for the in-kernel module, just return either - remove the version information completely from the kernel module MODULE_VERSION + drop BATADV_ATTR_VERSION + modifying batctl to fetch that from uname(). But of course, that would break old batctl versions [1] - or by setting BATADV_SOURCE_VERSION to UTS_RELEASE (+suffix?) or UTS_VERSION But this wasn't well received when mentioning it to Simon+Linus (but I could misremember the persons involved here). Kind regards, Sven [1] https://lore.kernel.org/r/20201205085604.1e3fcaee@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com --nextPart4755678.kQq0lBPeGt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAmPc1f8ACgkQXYcKB8Em e0YJEg/+IsrzHhNRdrlwtYcrox6niuIZH4TosdhIe9tRwjypwP4GGM+IFOxlWA4n TnNiryOeZhMwUfmqr+ntzIaWFxK9xzOfND1xNQRyBU9l1slWOctPg+1oh+7oGq86 fBEprCqn61Wu90fSM1LuTxiDTRsw2xFGeasOmwqJ3/u8IeGAa05WusuuaIs3hlf6 hUH+ih1gS1HLvuHEyIaFq1wRmJoMxB6Obg6v4ZAJshj3TnDnVGkFVYybI6/04ZAq 545/4VLmOww8mV8Gn763QkQ5gak1E25KhUrYO8neP7SFB1UXOx6GFPpwceiS8+WK I50n7weW3V/y+svyMvdJF/HMpY9smGanGBfoWvCpl04j/38L2wdUng3B9aNwOnFL EJJa+5guEN3P6gQshKmRda5fn2LW8oNEgcpZepEFFiAnRKSc0RdEXU62IicFsI1a GHXB588tbk23NA2fD0lVjyHDrLjLH8xLdnUP7wAizr0u4tINDVQphrHvGnF0Lx5K BlNOqcm3xHLX0fMzjrykIP69q2rwoyNOE9nJjfPgjBwGulgaMX05XXbXPmTYaosN 1n3yrWjfl4jXXA0aoE2OXHF4xm16D/0z+sAeqBef3xu5/BlZF7fPYf9ph/YuvYh3 A8EZB8Yu36GkF4cUO51unMyrSk1zQ/nVsl6U5SLgJdsKq6yPU8A= =xU8d -----END PGP SIGNATURE----- --nextPart4755678.kQq0lBPeGt--