From: Antoine van Gelder <antoine@7degrees.co.za>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanup
Date: Tue, 14 Jul 2009 15:32:31 +0200 [thread overview]
Message-ID: <F51A1DAE-D376-454C-8C39-2A1680CBCC6A@7degrees.co.za> (raw)
In-Reply-To: <20090714132004.GN19071@ma.tech.ascom.ch>
On 14 Jul 2009, at 15:20 , Andrew Lunn wrote:
> What are peoples opinion about this? Should i spend a little time
> cleaning up all the files? Some code needs refactoring a little, to
> reducing the nesting, creating more helper functions, but mostly its
> white space changes. However such changes can cause pain when trying
> to merge in other work people who diff's are against before the
> cleanup. Does anybody have any major patches?
I have a minor patch outstanding against the vis server but it
wouldn't be affected by a cleanup.
Very happy with the decision to do a clean-up.
- a
next prev parent reply other threads:[~2009-07-14 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 13:09 [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanup Andrew Lunn
2009-07-14 13:20 ` Andrew Lunn
2009-07-14 13:32 ` Antoine van Gelder [this message]
2009-07-14 13:57 ` [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanupy Andrew Lunn
2009-07-14 13:38 ` [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanup Sven Eckelmann
2009-07-14 14:48 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F51A1DAE-D376-454C-8C39-2A1680CBCC6A@7degrees.co.za \
--to=antoine@7degrees.co.za \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).