b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: yuzhe <yuzhe@nfschina.com>
To: Sven Eckelmann <sven@narfation.org>,
	mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com
Cc: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, liqiong@nfschina.com,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] batman-adv: remove unnecessary type castings
Date: Tue, 26 Apr 2022 17:52:19 +0800	[thread overview]
Message-ID: <e4525347-f3b1-440c-b72b-4b7a6830a0d1@nfschina.com> (raw)
In-Reply-To: <2133162.nbW41nx31j@ripper>

I agree, this patch is better. And I have tested, no sparse warning anymore.

Thank your for your help.

       

在 2022/4/25 20:50, Sven Eckelmann 写道:

     

>        
> On Monday, 25 April 2022 13:36:35 CEST Yu Zhe wrote:
>        
>>          
>> remove unnecessary void* type castings.
>>
>> Signed-off-by: Yu Zhe<yuzhe@nfschina.com>
>> ---
>>   net/batman-adv/translation-table.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>        
>        
> If you send a second version then please use `git format-patch -v2 ...` to
> format the patch. Now it looks in patchworks like you've resent the first
> version again. And please also add a little changelog after "---" which
> explains what you've changed. It is trivial in this little patch but still
> might be useful.
>
> Regarding the patch: Now you've removed bridge_loop_avoidance.c +
> batadv_choose_tt instead of fixing your patch. I would really prefer this
> patch version:
>
> https://git.open-mesh.org/linux-merge.git/commitdiff/8864d2fcf04385cabb8c8bb159f1f2ba5790cf71
>
> Kind regards,
> 	Sven
>      

  reply	other threads:[~2022-04-26  9:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220421154829.9775-1-yuzhe@nfschina.com>
2022-04-22  2:20 ` [PATCH] batman-adv: remove unnecessary type castings kernel test robot
2022-04-22  2:41 ` kernel test robot
2022-04-22  2:51 ` kernel test robot
2022-04-22  5:07 ` kernel test robot
2022-04-22  7:55 ` Sven Eckelmann
2022-04-25 11:14   ` yuzhe
2022-04-25 11:36 ` Yu Zhe
2022-04-25 12:50   ` Sven Eckelmann
2022-04-26  9:52     ` yuzhe [this message]
2022-04-26 10:29   ` [PATCH v2] " Yu Zhe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4525347-f3b1-440c-b72b-4b7a6830a0d1@nfschina.com \
    --to=yuzhe@nfschina.com \
    --cc=a@unstable.cc \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liqiong@nfschina.com \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sven@narfation.org \
    --cc=sw@simonwunderlich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).