From: Jens Axboe <axboe@kernel.dk>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>, fio@vger.kernel.org
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
Dmitry Fomichev <Dmitry.Fomichev@wdc.com>,
Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH 0/2] Fix job completion failure for sequential IOs with holes
Date: Fri, 1 Oct 2021 11:17:26 -0600 [thread overview]
Message-ID: <bbb27437-ace2-f276-f68f-072e1d95d18d@kernel.dk> (raw)
In-Reply-To: <20211001103257.4130231-1-shinichiro.kawasaki@wdc.com>
On 10/1/21 4:32 AM, Shin'ichiro Kawasaki wrote:
> Commit 499cded5f435 ("Fix for loop count issue when do_verify=0 (#1093)")
> triggered the failure of test case #7 of t/run-fio-tests.py. The test case
> runs sequential read workload with holes and checks amount of read data. The
> commit affected job completion condition, and resulted in unexpected larger
> read data and the test case failure.
>
> This series has two patches to address the issue. The first patch reverts the
> commit, and the second patch proposes different fix for the loop count issue
> with do_verify=0 option. I used the workload recorded in github issue #1093 to
> confirm this second patch fixes the loop count issue.
Good catch - applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-10-01 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 10:32 [PATCH 0/2] Fix job completion failure for sequential IOs with holes Shin'ichiro Kawasaki
2021-10-01 10:32 ` [PATCH 1/2] Revert "Fix for loop count issue when do_verify=0 (#1093)" Shin'ichiro Kawasaki
2021-10-01 10:32 ` [PATCH 2/2] Refer td->loops instead of td->o.loops to fix loop count issue Shin'ichiro Kawasaki
2021-10-01 17:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb27437-ace2-f276-f68f-072e1d95d18d@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=Dmitry.Fomichev@wdc.com \
--cc=fio@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.