From: Mark Brown <broonie@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christian Brauner <brauner@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Tobias Klauser <tklauser@distanz.ch>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/clone3: Skip new time namespace test when unsupported
Date: Fri, 20 Oct 2023 12:46:37 +0100 [thread overview]
Message-ID: <bca5db5e-2536-4e3f-8d04-7e0e13203ad6@sirena.org.uk> (raw)
In-Reply-To: <20231019163538.69d494a0af0560a492b5ffb4@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
On Thu, Oct 19, 2023 at 04:35:38PM -0700, Andrew Morton wrote:
> On Fri, 20 Oct 2023 00:08:12 +0100 Mark Brown <broonie@kernel.org> wrote:
> > Use a filter function to skip the time namespace test on systems with
> > !CONFIG_TIME_NS. This reworks a fix originally done by Tiezhu Yang prior
> > to the refactoring in 34dce23f7e40 ("selftests/clone3: Report descriptive
> > test names"). The changelog from their fix explains the issue very clearly:
> I was about to send Tiezhu Yang's fix to Linus. I'll rebase mm-hotfixes-stable
> to drop that patch, so you own it now!
> Please note that your version lacks an explicit cc:stable, but I suppose the
> stablebots will scoop it up anyway.
I think I was expecting Tiezhu's version to still get sent and then the
two versions to get merged - the refactoring that caused the conflict is
very clearly not stable material.
> > Original-fix-from: Tiezhu Yang <yangtiezhu@loongson.cn>
> "Original-fix-from" isn't a thing. In fact it seems to be the first
> time this has been used. Grepping for "Original-.*:" shows
> all sorts of innovations, including "Based-on-the-original-screenplay-by:".
> I guess Documentation/process/submitting-patches.rst and checkpatch
> lost this fight a long time ago.
Well, they've always been documenting existing practice.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-10-20 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 23:08 [PATCH] selftests/clone3: Skip new time namespace test when unsupported Mark Brown
2023-10-19 23:35 ` Andrew Morton
2023-10-20 1:34 ` Tiezhu Yang
2023-10-20 11:46 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca5db5e-2536-4e3f-8d04-7e0e13203ad6@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tklauser@distanz.ch \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.