Re: [Qemu-devel] [RFC 11/19] fuzz: add direct send/receive in qtest client

From: Thomas Huth <thuth@redhat.com>
To: "Oleinik, Alexander" <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	bsd@redhat.com, superirishdonkey@gmail.com, stefanha@redhat.com,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC 11/19] fuzz: add direct send/receive in qtest client
Date: Thu, 25 Jul 2019 11:10:36 +0200	[thread overview]
Message-ID: <bddfc0c3-e530-9ffb-89f7-bca88288f4f4@redhat.com> (raw)
In-Reply-To: <20190725032321.12721-12-alxndr@bu.edu>

On 25/07/2019 05.23, Oleinik, Alexander wrote:
> Directly interact with tests/libqtest.c functions
> 
> Signed-off-by: Alexander Oleinik <alxndr@bu.edu>
> ---
>  qtest.c | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
[...]
> @@ -748,8 +755,11 @@ static void qtest_event(void *opaque, int event)
>          break;
>      }
>  }
> -
> +#ifdef CONFIG_FUZZ
> +void qtest_init_server(const char *qtest_chrdev, const char *qtest_log, Error **errp)
> +#else
>  void qtest_init(const char *qtest_chrdev, const char *qtest_log, Error **errp)
> +#endif
>  {
>      Chardev *chr;

Even without your fuzzer series, it's somewhat confusing that we have a
qtest_init() function here that is completely different from the
qtest_init() function in tests/libqtest.c ...
Maybe you could send a separate patch that renames the qtest_init() here
always to qtest_init_server() and change the calling of the function in
vl.c, too?

 Thomas