From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] block: Introduce BdrvChildRole.update_filename
Date: Mon, 25 Sep 2017 12:58:08 -0500 [thread overview]
Message-ID: <bdecad1e-5adc-f8c1-aa1d-c73715e48c77@redhat.com> (raw)
In-Reply-To: <20170925122808.14561-2-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On 09/25/2017 07:28 AM, Kevin Wolf wrote:
> There is no good reason for bdrv_drop_intermediate() to know the active
> layer above the subchain it is operating on - even more so, because
> the assumption that there is a single active layer above it is not
> generally true.
>
> In order to prepare removal of the active parameter, use a BdrvChildRole
> callback to update the backing file string in the overlay image instead
> of directly calling bdrv_change_backing_file().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/block/block_int.h | 6 ++++++
> block.c | 33 ++++++++++++++++++++++++++++-----
> 2 files changed, 34 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-09-25 17:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:28 [Qemu-devel] [PATCH 0/5] commit: Support multiple roots above top node Kevin Wolf
2017-09-25 12:28 ` [Qemu-devel] [PATCH 1/5] block: Introduce BdrvChildRole.update_filename Kevin Wolf
2017-09-25 17:58 ` Eric Blake [this message]
2017-09-25 12:28 ` [Qemu-devel] [PATCH 2/5] commit: Support multiple roots above top node Kevin Wolf
2017-09-25 19:38 ` Eric Blake
2017-09-26 17:35 ` Kevin Wolf
2017-09-25 12:28 ` [Qemu-devel] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in common.qemu Kevin Wolf
2017-09-25 19:43 ` Eric Blake
2017-09-25 12:28 ` [Qemu-devel] [PATCH 4/5] qemu-iotests: Test commit block job where top has two parents Kevin Wolf
2017-09-25 20:19 ` Eric Blake
2017-10-05 16:28 ` Kevin Wolf
2017-09-25 12:28 ` [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs Kevin Wolf
2017-09-25 20:47 ` Eric Blake
2017-09-25 20:02 ` [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node John Snow
2017-09-26 7:59 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdecad1e-5adc-f8c1-aa1d-c73715e48c77@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.