From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Nir Soffer <nsoffer@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an L1 entry
Date: Tue, 21 Jan 2020 13:15:08 +0100 [thread overview]
Message-ID: <beb52423-2b92-04ac-666a-8c74273ce135@redhat.com> (raw)
In-Reply-To: <71f34d4ae4b367b32fb36134acbf4f4f7ee681f4.1579374329.git.berto@igalia.com>
[-- Attachment #1.1: Type: text/plain, Size: 646 bytes --]
On 18.01.20 20:09, Alberto Garcia wrote:
> When updating an L1 entry the qcow2 driver writes a (512-byte) sector
> worth of data to avoid a read-modify-write cycle. Instead of always
> writing 512 bytes we should follow the alignment requirements of the
> storage backend.
>
> (the only exception is when the alignment is larger than the cluster
> size because then we could be overwriting data after the L1 table)
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/qcow2-cluster.c | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-21 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 19:09 [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates Alberto Garcia
2020-01-18 19:09 ` [PATCH v3 1/5] qcow2: Don't round the L1 table allocation up to the sector size Alberto Garcia
2020-01-18 19:09 ` [PATCH v3 2/5] qcow2: Tighten cluster_offset alignment assertions Alberto Garcia
2020-01-18 19:09 ` [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an L1 entry Alberto Garcia
2020-01-21 12:15 ` Max Reitz [this message]
2020-01-18 19:09 ` [PATCH v3 4/5] qcow2: Don't require aligned offsets in qcow2_co_copy_range_from() Alberto Garcia
2020-01-21 12:16 ` Max Reitz
2020-01-18 19:09 ` [PATCH v3 5/5] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value Alberto Garcia
2020-01-21 12:19 ` Max Reitz
2020-01-21 12:20 ` [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beb52423-2b92-04ac-666a-8c74273ce135@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.