From: AliOS system security <alios_sys_security@linux.alibaba.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] mksysmap: Fix the mismatch of '.L' symbols in System.map
Date: Tue, 2 Jun 2020 14:41:49 +0800 [thread overview]
Message-ID: <befdf38d-631d-8722-df7b-6e670f9c0bc8@linux.alibaba.com> (raw)
In-Reply-To: <CAK7LNAS290zRibWqbu1AxQ1W9afPR21OYSia+xkqwoot9zRd2w@mail.gmail.com>
Thanks for your suggestion, I will use my personal account to post
a new version later, and amend this comment.
On 2020/6/1 19:01, Masahiro Yamada wrote:
> On Sun, May 31, 2020 at 7:28 PM AliOS system security
> <alios_sys_security@linux.alibaba.com> wrote:
>>
>> When System.map was generated, the kernel used mksysmap to filter the
>> kernel symbols, but all the symbols with the second letter 'L' in the
>> kernel were filtered out, not just the symbols starting with 'dot + L'.
>>
>> For example:
>> ashimida@ubuntu:~/linux$ cat System.map |grep ' .L'
>> ashimida@ubuntu:~/linux$ nm -n vmlinux |grep ' .L'
>> ffff0000088028e0 t bLength_show
>> ......
>> ffff0000092e0408 b PLLP_OUTC_lock
>> ffff0000092e0410 b PLLP_OUTA_lock
>>
>> I see that in the original patch[1], the original intent should be to
>> filter all local symbols starting with '.L', so I wonder if the code
>> here may add a '\' before '.L'?
>
>
> You are right, but please avoid the interrogatory sentence.
>
> Shall I reword as follows?
>
>
> The original intent should be to filter out all local symbols
> starting with '.L', so the dot should be escaped.
>
>
>
>
>
>>
>> [1]. mksysmap: Add h8300 local symbol pattern
>>
>> Signed-off-by: AliOS system security
<alios_sys_security@linux.alibaba.com>
>> ---
>> scripts/mksysmap | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/mksysmap b/scripts/mksysmap
>> index a35acc0..9aa23d1 100755
>> --- a/scripts/mksysmap
>> +++ b/scripts/mksysmap
>> @@ -41,4 +41,4 @@
>> # so we just ignore them to let readprofile continue to work.
>> # (At least sparc64 has __crc_ in the middle).
>>
>> -$NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\(
.L\)' > $2
>> +$NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\(
\.L\)' > $2
>> --
>> 2.7.4
>>
>
>
next prev parent reply other threads:[~2020-06-02 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 10:28 [PATCH] mksysmap: Fix the mismatch of '.L' symbols in System.map AliOS system security
2020-06-01 11:01 ` Masahiro Yamada
2020-06-02 6:41 ` AliOS system security [this message]
2020-06-02 1:50 ` Masahiro Yamada
2020-06-02 7:45 ` [PATCH v2] " ashimida
2020-06-02 14:42 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=befdf38d-631d-8722-df7b-6e670f9c0bc8@linux.alibaba.com \
--to=alios_sys_security@linux.alibaba.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.