Re: [Libtirpc-devel] [PATCH - rpcbind] Provide systemd unit files for rpcbind

From: Steve Dickson <SteveD@redhat.com>
To: NeilBrown <neilb@suse.com>, Thorsten Kukuk <kukuk@suse.de>
Cc: linux-nfs@vger.kernel.org, libtirpc-devel@lists.sourceforge.net
Subject: Re: [Libtirpc-devel] [PATCH - rpcbind] Provide systemd unit files for rpcbind
Date: Wed, 2 Nov 2016 17:31:25 -0400	[thread overview]
Message-ID: <bf20e38d-6129-688f-42b8-aad97334daea@RedHat.com> (raw)
In-Reply-To: <87a8dhr39t.fsf@notabene.neil.brown.name>

On 11/02/2016 05:16 PM, NeilBrown wrote:
> On Thu, Nov 03 2016, Steve Dickson wrote:
>
>> On 11/02/2016 09:49 AM, Thorsten Kukuk wrote:
>>> On Wed, Nov 02, Steve Dickson wrote:
>>>
>>>> I just took a look and we don't set that... Here is what we
>>>> set in Fedora
>>>>
>>>> RPCBDIR=/tmp
>>>> %configure CFLAGS="$CFLAGS" LDFLAGS="-pie" \
>>>>     --enable-warmstarts \
>>>>     --with-statedir="$RPCBDIR" \
>>>>     --with-rpcuser="$RPCBUSR" \
>>>>     --with-nss-modules="files altfiles" \
>>>>     --enable-libwrap \
>>>>     --enable-debug
>>> The rpcbind Makefile has:
>>> bin_PROGRAMS = rpcbind rpcinfo
>>>
>>> So per default, "make install" should install it into /usr/bin
>>> and the patch from Niel with bin is correct.
>> You are correct... In  %install does the following
>>
>> mv -f ${RPM_BUILD_ROOT}%{_bindir}/rpcbind ${RPM_BUI
>>> Thanks,
>>> NeilBrown
>> LD_ROOT}/sbin
>> mv -f ${RPM_BUILD_ROOT}%{_bindir}/rpcinfo ${RPM_BUILD_ROOT}%{_sbindir}
>>
>> Since rpcbind lives in /usr/sbin in the majority distro
>> I'm going to change the Makefile.am so "make install" 
>> will do the right thing... Any objections?
> If you do it by changing the default for bindir, or by introducing an
> sbindir that can be changed with configure, then no objections from me.
> I'm not sure it really needs fixing, but I don't object to be being
> fixed.
>
Yes... basically

-bin_PROGRAMS = rpcbind rpcinfo
+sbin_PROGRAMS = rpcbind rpcinfo

and that seems to work... all this means the rpm spec file
will have to be tweaked when a new release is made.

All I'll for checking in these systemd file with the comments
from the systemd people and the bin=>sbin change.

How about a respin?

steved.