All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jules Irenge <jbi.octave@gmail.com>
To: boqun.feng@gmail.com
Cc: dvhart@infradead.org, peterz@infradead.org, mingo@redhat.com,
	tglx@linutronix.de, linux-kernel@vger.kernel.org,
	Jules Irenge <jbi.octave@gmail.com>
Subject: [PATCH 11/11] futex: Add missing annotation for futex_wait_queue_me()
Date: Sun,  9 Feb 2020 22:50:42 +0000	[thread overview]
Message-ID: <bf54651bbf0b2168ca86c53e899be1c8a245d933.1581282103.git.jbi.octave@gmail.com> (raw)
In-Reply-To: <cover.1581282103.git.jbi.octave@gmail.com>

Sparse reports a warning at futex_wait_queue_me()

warning: context imbalance in futex_wait_queue_me() - unexpected unlock

The root cause is a missing annotation at futex_wait_queue_me()

Add the missing annotation  __releases(&hb->lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 kernel/futex.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/futex.c b/kernel/futex.c
index 5263cce46c06..16c6c40dbd68 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2679,6 +2679,7 @@ static int fixup_owner(u32 __user *uaddr, struct futex_q *q, int locked)
  */
 static void futex_wait_queue_me(struct futex_hash_bucket *hb, struct futex_q *q,
 				struct hrtimer_sleeper *timeout)
+	__releases(&hb->lock)
 {
 	/*
 	 * The task state is guaranteed to be set before another task can
-- 
2.24.1


  parent reply	other threads:[~2020-02-09 22:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0/11>
2020-02-09 22:24 ` [PATCH 00/11] Lock warning cleanup Jules Irenge
2020-02-09 22:27   ` [PATCH 01/11] hrtimer: Add missing annotation to lock_hrtimer_base() Jules Irenge
2020-02-09 22:29   ` [PATCH 02/11] futex: Add missing annotation for wake_futex_pi() Jules Irenge
2020-02-09 22:30   ` [PATCH 03/11] futex: Add missing annotation for fixup_pi_state_owner() Jules Irenge
2020-02-09 22:33   ` [PATCH 04/11] perf/ring_buffer: Add missing annotation to perf_output_end() Jules Irenge
2020-02-09 22:37   ` [PATCH 05/11] sched/fair: Add missing annotation for nohz_newidle_balance() Jules Irenge
2020-02-09 22:39   ` [PATCH 06/11] sched/deadline: Add missing annotation for dl_task_offline_migration() Jules Irenge
2020-02-10  8:07     ` Juri Lelli
2020-02-09 22:44   ` [PATCH 07/11] fs_pin: Add missing annotation for pin_kill() declaration Jules Irenge
2020-02-09 22:45   ` [PATCH 08/11] fs_pin: Add missing annotation for pin_kill() definition Jules Irenge
2020-02-09 22:48   ` [PATCH 09/11] kasan: add missing annotation for start_report() Jules Irenge
2020-02-10  7:27     ` Dmitry Vyukov
2020-02-10  7:27       ` Dmitry Vyukov
2020-02-09 22:49   ` [PATCH 10/11] kasan: add missing annotation for end_report() Jules Irenge
2020-02-10  7:27     ` Dmitry Vyukov
2020-02-10  7:27       ` Dmitry Vyukov
2020-02-09 22:50   ` Jules Irenge [this message]
2020-02-10  5:06   ` [PATCH 00/11] Lock warning cleanup Boqun Feng
2020-02-10 23:09     ` Jules Irenge
2020-02-10 23:09       ` Jules Irenge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf54651bbf0b2168ca86c53e899be1c8a245d933.1581282103.git.jbi.octave@gmail.com \
    --to=jbi.octave@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.