Re: [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com,
	deller@gmx.de, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off
Date: Thu, 14 Mar 2024 09:16:15 +0100	[thread overview]
Message-ID: <bf7b7e88-a7b4-427d-b38c-d3c9cc568aaf@suse.de> (raw)
In-Reply-To: <20240313180027.GB96726@ravnborg.org>

Hi

Am 13.03.24 um 19:00 schrieb Sam Ravnborg:
> Hi Thomas,
>
> On Wed, Mar 13, 2024 at 04:45:02PM +0100, Thomas Zimmermann wrote:
>> The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for
>> any other value in fb_blank. But the field fb_blank in struct
>> backlight_properties is deprecated and should not be used any
>> longer.
>>
>> Replace the test for fb_blank in omap's backlight code with a
>> simple boolean parameter and push the test into the update_status
>> helper. Instead of reading fb_blank directly, decode the backlight
>> device's status with backlight_is_blank().
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> My biased opinion is that the approach in this patch is a little bit
> better:
> https://lore.kernel.org/lkml/20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org/
>
> I never came around resending this series it seems.

Oh, that series has been around for over a year. I don't care about 
which patches go in as long as they remove the dependency on 
<linux/fb.h>. I saw that Dan has already r-b'ed the current patchset, 
but if you prefer I'll adopt yours.

Best regards
Thomas

>
> 	Sam

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)