Re: [bitbake-devel] [PATCH] upstream source tracing: data collection (patch 2/3)

[Alberto Pianon <alberto@pianon.eu>]

On 2023-05-02 12:44, Alberto Pianon wrote:
> On 2023-04-28 15:47, Khem Raj wrote:
>> On Fri, Apr 28, 2023 at 12:47 AM Alberto Pianon <alberto@pianon.eu> 
>> wrote:
>>> 
>>> 
>>> On 2023-04-27 21:40, Khem Raj wrote:
>>> > On Thu, Apr 27, 2023 at 7:10 AM Alberto Pianon <alberto@pianon.eu>
>>> > wrote:
>>> >>
>>> >> Hi Khem,
>>> >>
>>> >> Il 2023-04-27 09:02 Alberto Pianon ha scritto:
>>> >>
>>> >>      Il 2023-04-27 08:56 Khem Raj ha scritto:
>>> >>
>>> >>          On Wed, Apr 26, 2023 at 10:19 PM Alberto Pianon
>>> >> <alberto@pianon.eu> wrote:
>>> >>
>>> >>
>>> >>              Il 2023-04-27 07:14 Alberto Pianon ha scritto:
>>> >>
>>> >>                  Could you please check if this is really the case in
>>> >> your case?
>>> >>                  You'd need to go to
>>> >> meta/recipes-sato/matchbox-panel-2/files
>>> >>                  (check where the layer is located in your filesystem)
>>> >> and do
>>> >>
>>> >>
>>> >>              Of course it is located at
>>> >>              /mnt/b/yoe/master/sources/poky/meta/recipes-sato/m
>>> >>
>>> >> atchbox-panel-2/files/0001-applets-systray-Allow-icons-to-be-smaller.patch
>>> >>
>>> >>              :)
>>> >>
>>> >>              Please check also the other two files for which you get
>>> >> the
>>> >> warnings
>>> >>
>>> >>
>>> >>          My distro uses git submodules at top level and poky is a
>>> >> submodule see
>>> >>          https://github.com/yoedistro/yoe-distro
>>> >>
>>> >>          git rev-parse --is-inside-work-tree
>>> >>          true
>>> >>
>>> >>          % git status
>>> >>          HEAD detached at 5a944d32a1
>>> >>          nothing to commit, working tree clean
>>> >>
>>> >>
>>> >>
>>> >>      so something's wrong... I'll build your distro and try to find
>>> >> the
>>> >> problem
>>> >>      thanks
>>> >>
>>> >>
>>> >> first of all kudos for Yoe, it's one of the simpler-to-build distros I
>>> >> ever tried, it seems you did a very good job there :)
>>> >>
>>> >> BTW, I couldn't reproduce the problem, since I don't get any warning
>>> >> message, and the upstream sources are correctly identified, eg. in
>>> >> build/tmp/work/cortexa72-yoe-linux/matchbox-keyboard/0.1.1-r0/temp/matchbox-keyboard-0.1.1.unpack.trace.json.zst
>>> >> I find:
>>> >>
>>> >>
>>> >> "git+https://github.com/yoedistro/poky@5a944d32a1e2baff34eb03b07ec094421a7a8773#meta/recipes-sato/m
>>> >> atchbox-keyboard/files/0001-desktop-file-Hide-the-keyboard-from-app-list.patch":
>>> >> {
>>> >>      "download_location":
>>> >> "git+https://github.com/yoedistro/poky@5a944d32a1e2baff34eb03b07ec094421a7a8773#meta/recipes-sato/matchbox-keyboard/files/0001-desktop-file-Hide-the-keyboard-from-app-list.patch",
>>> >>      "src_uri":
>>> >> "file://0001-desktop-file-Hide-the-keyboard-from-app-list.patch",
>>> >>      "layer": "meta",
>>> >>      "files": {
>>> >>        "": {
>>> >>          "sha1": "856c3f6bf74a1b11e90b0ade0b4aeecbb3babfff",
>>> >>          "paths_in_workdir": [
>>> >>            "0001-desktop-file-Hide-the-keyboard-from-app-list.patch"
>>> >>          ]
>>> >>        }
>>> >>      }
>>> >>    },
>>> >>
>>> >> ... which is the expected result (while on the same file you get a
>>> >> warning that the download_location has not been identified).
>>> >>
>>> >> Could you please double-check the output of git commands in
>>> >> /mnt/b/yoe/master/sources/poky/meta/recipes-sato/matchbox-keyboard/files/
>>> >> and in other dirs?
>>> >
>>> > [kraj@apollo
>>> > /mnt/b/yoe/master/sources/poky/meta/recipes-sato/matchbox-keyboard/files]
>>> > % git rev-parse --is-inside-work-tree
>>> >
>>> > true
>>> >
>>> > Secondly, I am building on archlinux which is uptodate as of
>>> > yesterday, Default yoe builds in a debian bullseye container
>>> > so I wonder if thats what is mattering here. in order to not use
>>> > container with yoe add
>>> >
>>> > cp local.sh.example local.sh
>>> >
>>> > and add below line to local.sh
>>> >
>>> > export DOCKER_REPO=none
>>> >
>>> > Then source envsetup again and build.
>>> >
>>> 
>>> I tried that, but I got the same (good) results, I get none of the
>>> warnings you are getting. I'm on Ubuntu 22.04 though... which 
>>> archlinux
>>> version are you on?
>> 
>> arch is a rolling distro i am uptodate as of today
>> 
> 
> yep, you're right :blush:
> 
> I set up a build machine with archlinux, updated as of today, installed 
> required packages (base-devel chrpath cpio diffstat gawk gcc git 
> inetutils iputils mesa lz4 python-pylint python3 python-gitpython 
> python-jinja python-pexpect python-pip python-subunit rpcsvc-proto 
> socat texinfo unzip wget xterm xz zstd) and built Yoe without docker 
> (to be sure, I didn't event install it, and set `export 
> DOCKER_REPO=none`).
> 
> I still get none of the warning messages you are getting, everything 
> works, and trace json files are correctly generated.
> 
> Could you please try again from a fresh Yoe git clone?

Hi Khem,

Following on our discussion and the input from Richard, could you try to 
change line 217 of bb.fetch2.trace in the following way (adding a "." 
pathspec to the git status command), and see if you get rid of those 
warnings?

stdout, _ = bb.process.run(["git", "status", "--porcelain", "."], 
cwd=git_dir)

Thank you!

Alberto