From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60641C77B73 for ; Tue, 2 May 2023 16:41:44 +0000 (UTC) Received: from server3.justice4all.it (server3.justice4all.it [95.217.19.36]) by mx.groups.io with SMTP id smtpd.web10.1077.1683045699728308750 for ; Tue, 02 May 2023 09:41:41 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@pianon.eu header.s=mail20151219 header.b=S0H/z2CA; spf=pass (domain: pianon.eu, ip: 95.217.19.36, mailfrom: alberto@pianon.eu) Received: from localhost (localhost [127.0.0.1]) by server3.justice4all.it (Postfix) with ESMTP id D88395C0096; Tue, 2 May 2023 18:41:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pianon.eu; h= message-id:references:in-reply-to:subject:subject:from:from:date :date:content-transfer-encoding:content-type:content-type :mime-version; s=mail20151219; t=1683045693; x=1684860094; bh=Em DdaDOgs0qAo13eA0cuib/0sqYKePmpbE4hyN7/MSI=; b=S0H/z2CARJpH1MeKst ezxkRQIs4nkRSS34V/vG4FTaMmFvmt/hL9dl1Mrlb7bJryX8vUTIUECPFs9KFky2 ALPK2J3SeLhW39184wwjEmyIwdxb+QsdFHaVvtj+csIoJM5tsILJ/16IkZ3v+jsE vXGlT2u0Cpo68kCSeXRhQi2/E= X-Virus-Scanned: Debian amavisd-new at server3.justice4all.it Received: from server3.justice4all.it ([127.0.0.1]) by localhost (server3.justice4all.it [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id v7bonxVNOeJp; Tue, 2 May 2023 18:41:33 +0200 (CEST) Received: from pianon.eu (localhost [127.0.0.1]) (Authenticated sender: alberto@pianon.eu) by server3.justice4all.it (Postfix) with ESMTPA id D35C85C0095; Tue, 2 May 2023 18:41:33 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Tue, 02 May 2023 18:41:33 +0200 From: Alberto Pianon To: Khem Raj Cc: bitbake-devel@lists.openembedded.org, richard.purdie@linuxfoundation.org, jpewhacker@gmail.com, carlo@piana.eu Subject: Re: [bitbake-devel] [PATCH] upstream source tracing: data collection (patch 2/3) In-Reply-To: <0ebebbaf89c2770326e0d26d12a5179e@pianon.eu> References: <20230420062113.134546-1-alberto@pianon.eu> <8dfce9c36a557f67be4dc6d37417ac63@pianon.eu> <1759B8A6082B56AB.32698@lists.openembedded.org> <0ebebbaf89c2770326e0d26d12a5179e@pianon.eu> Message-ID: <0547cb8b3b0caa432769473fdd0ceb38@pianon.eu> X-Sender: alberto@pianon.eu Content-Transfer-Encoding: quoted-printable List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 02 May 2023 16:41:44 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/14766 On 2023-05-02 12:44, Alberto Pianon wrote: > On 2023-04-28 15:47, Khem Raj wrote: >> On Fri, Apr 28, 2023 at 12:47=E2=80=AFAM Alberto Pianon =20 >> wrote: >>>=20 >>>=20 >>> On 2023-04-27 21:40, Khem Raj wrote: >>> > On Thu, Apr 27, 2023 at 7:10=E2=80=AFAM Alberto Pianon >>> > wrote: >>> >> >>> >> Hi Khem, >>> >> >>> >> Il 2023-04-27 09:02 Alberto Pianon ha scritto: >>> >> >>> >> Il 2023-04-27 08:56 Khem Raj ha scritto: >>> >> >>> >> On Wed, Apr 26, 2023 at 10:19=E2=80=AFPM Alberto Pianon >>> >> wrote: >>> >> >>> >> >>> >> Il 2023-04-27 07:14 Alberto Pianon ha scritto: >>> >> >>> >> Could you please check if this is really the case= in >>> >> your case? >>> >> You'd need to go to >>> >> meta/recipes-sato/matchbox-panel-2/files >>> >> (check where the layer is located in your filesys= tem) >>> >> and do >>> >> >>> >> >>> >> Of course it is located at >>> >> /mnt/b/yoe/master/sources/poky/meta/recipes-sato/m >>> >> >>> >> atchbox-panel-2/files/0001-applets-systray-Allow-icons-to-be-small= er.patch >>> >> >>> >> :) >>> >> >>> >> Please check also the other two files for which you g= et >>> >> the >>> >> warnings >>> >> >>> >> >>> >> My distro uses git submodules at top level and poky is a >>> >> submodule see >>> >> https://github.com/yoedistro/yoe-distro >>> >> >>> >> git rev-parse --is-inside-work-tree >>> >> true >>> >> >>> >> % git status >>> >> HEAD detached at 5a944d32a1 >>> >> nothing to commit, working tree clean >>> >> >>> >> >>> >> >>> >> so something's wrong... I'll build your distro and try to fin= d >>> >> the >>> >> problem >>> >> thanks >>> >> >>> >> >>> >> first of all kudos for Yoe, it's one of the simpler-to-build distr= os I >>> >> ever tried, it seems you did a very good job there :) >>> >> >>> >> BTW, I couldn't reproduce the problem, since I don't get any warni= ng >>> >> message, and the upstream sources are correctly identified, eg. in >>> >> build/tmp/work/cortexa72-yoe-linux/matchbox-keyboard/0.1.1-r0/temp= /matchbox-keyboard-0.1.1.unpack.trace.json.zst >>> >> I find: >>> >> >>> >> >>> >> "git+https://github.com/yoedistro/poky@5a944d32a1e2baff34eb03b07ec= 094421a7a8773#meta/recipes-sato/m >>> >> atchbox-keyboard/files/0001-desktop-file-Hide-the-keyboard-from-ap= p-list.patch": >>> >> { >>> >> "download_location": >>> >> "git+https://github.com/yoedistro/poky@5a944d32a1e2baff34eb03b07ec= 094421a7a8773#meta/recipes-sato/matchbox-keyboard/files/0001-desktop-file= -Hide-the-keyboard-from-app-list.patch", >>> >> "src_uri": >>> >> "file://0001-desktop-file-Hide-the-keyboard-from-app-list.patch", >>> >> "layer": "meta", >>> >> "files": { >>> >> "": { >>> >> "sha1": "856c3f6bf74a1b11e90b0ade0b4aeecbb3babfff", >>> >> "paths_in_workdir": [ >>> >> "0001-desktop-file-Hide-the-keyboard-from-app-list.patc= h" >>> >> ] >>> >> } >>> >> } >>> >> }, >>> >> >>> >> ... which is the expected result (while on the same file you get a >>> >> warning that the download_location has not been identified). >>> >> >>> >> Could you please double-check the output of git commands in >>> >> /mnt/b/yoe/master/sources/poky/meta/recipes-sato/matchbox-keyboard= /files/ >>> >> and in other dirs? >>> > >>> > [kraj@apollo >>> > /mnt/b/yoe/master/sources/poky/meta/recipes-sato/matchbox-keyboard/= files] >>> > % git rev-parse --is-inside-work-tree >>> > >>> > true >>> > >>> > Secondly, I am building on archlinux which is uptodate as of >>> > yesterday, Default yoe builds in a debian bullseye container >>> > so I wonder if thats what is mattering here. in order to not use >>> > container with yoe add >>> > >>> > cp local.sh.example local.sh >>> > >>> > and add below line to local.sh >>> > >>> > export DOCKER_REPO=3Dnone >>> > >>> > Then source envsetup again and build. >>> > >>>=20 >>> I tried that, but I got the same (good) results, I get none of the >>> warnings you are getting. I'm on Ubuntu 22.04 though... which=20 >>> archlinux >>> version are you on? >>=20 >> arch is a rolling distro i am uptodate as of today >>=20 >=20 > yep, you're right :blush: >=20 > I set up a build machine with archlinux, updated as of today, installed= =20 > required packages (base-devel chrpath cpio diffstat gawk gcc git=20 > inetutils iputils mesa lz4 python-pylint python3 python-gitpython=20 > python-jinja python-pexpect python-pip python-subunit rpcsvc-proto=20 > socat texinfo unzip wget xterm xz zstd) and built Yoe without docker=20 > (to be sure, I didn't event install it, and set `export=20 > DOCKER_REPO=3Dnone`). >=20 > I still get none of the warning messages you are getting, everything=20 > works, and trace json files are correctly generated. >=20 > Could you please try again from a fresh Yoe git clone? Hi Khem, Following on our discussion and the input from Richard, could you try to=20 change line 217 of bb.fetch2.trace in the following way (adding a "."=20 pathspec to the git status command), and see if you get rid of those=20 warnings? stdout, _ =3D bb.process.run(["git", "status", "--porcelain", "."],=20 cwd=3Dgit_dir) Thank you! Alberto