archive mirror
 help / color / mirror / Atom feed
From: Luca Ceresoli <>
To: "Svend Meyland Nicolaisen" <>
Subject: Re: [bitbake-devel] [PATCH] npmsw fetcher: Avoid instantiating Fetch class if url list is empty
Date: Tue, 18 Apr 2023 12:24:51 +0200	[thread overview]
Message-ID: <20230418122451.2e24ce87@booty> (raw)
In-Reply-To: <>

Hello Svend,

On Mon, 17 Apr 2023 23:12:28 +0200
"Svend Meyland Nicolaisen" <> wrote:

> Recipes containing both git and npmsw sources in the SRC_URI fail
> during fetch from the shrinkwrap. It seems that when the fetcher is
> fetching from the shrinkwrap, the SRCREV variable has been deleted but it
> till ends up fetching from the git source resulting in an error because
> SRCREV is undefined. The root cause of this is that the Fetch class defaults
> to urls from the SRC_URI when the urls parameter contains an empty list. This
> patch will ensure that Fetch is not instantiated if the urls list is empty.

Thank you, looks much better now! I have sent the e-mail in appropriate
ASCII so it can be applied with 'git am' here as Michael told you, and
you fixed the commit title.

There are still a couple things you should improve (good news: those
are easier).


 * All commit messages must include Signed-off-by (git commit -s)
 * Please substitute "PATCH" with "PATCH v2" if you are submitting a
   revised version after addressing feedback (or v3, v4 etc.) 
   (git commit -v<NUMBER>)

Can you resend with those fixed please?

Best regards,

Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering

  reply	other threads:[~2023-04-18 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 21:12 [PATCH] npmsw fetcher: Avoid instantiating Fetch class if url list is empty Svend Meyland Nicolaisen
2023-04-18 10:24 ` Luca Ceresoli [this message]
2023-04-18 20:56   ` Svend Meyland Nicolaisen
2023-04-19  7:46     ` [bitbake-devel] " Luca Ceresoli
  -- strict thread matches above, loose matches on Subject: below --
2023-04-16 20:07 public
2023-04-17  7:53 ` [bitbake-devel] " Luca Ceresoli
2023-04-17  9:26   ` Michael Opdenacker
2023-04-17 21:18     ` Svend Meyland Nicolaisen
2023-04-18  8:11       ` [bitbake-devel] " Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230418122451.2e24ce87@booty \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).