From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Alberto Pianon" <alberto@pianon.eu>
Cc: bitbake-devel@lists.openembedded.org,
richard.purdie@linuxfoundation.org, jpewhacker@gmail.com,
carlo@piana.eu
Subject: Re: [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process
Date: Fri, 21 Apr 2023 09:28:03 +0200 [thread overview]
Message-ID: <20230421092803.081e3cd6@booty> (raw)
In-Reply-To: <20230421070525.333494-1-alberto@pianon.eu>
Hello Alberto,
On Fri, 21 Apr 2023 09:05:23 +0200
"Alberto Pianon" <alberto@pianon.eu> wrote:
> From: Alberto Pianon <alberto@pianon.eu>
>
> License compliance, SBoM generation and CVE checking require to be able
> to trace each source file back to its corresponding upstream source. The
> current implementation of bb.fetch2 makes it difficult, especially when
> multiple sources are combined together.
>
> This patch provides an interface to solve the issue by implementing a
> process that unpacks each SRC_URI element into a temporary directory,
> creates an entrypoint to collect relevant provenance metadata on each
> source file, moves everything to the recipe rootdir, and saves metadata
> in a JSON file.
>
> This patch contains required modifications to fetchers' code plus a
> TraceUnpackBase class that implements the above described process. Data
> collection logic should be separately implemented by subclassing
> TraceUnpackBase, implementing _collect_data() and _process_data()
> methods.
>
> Splitting the above described solution in multiple patches aims
> at easing review and merge process, and also at decoupling the
> development of the data processing logic from the process that enables
> it.
>
> Signed-off-by: Alberto Pianon <alberto@pianon.eu>
Thank you for having fixed the subject! Now I can apply your patches
with a clean git commit.
Do you think the build failures I reported on the v1 series are fixed
by this v2? If you think so, then I can test v2 on the autobuilders.
Also, I see this patch set is not bisectable as well as v1: you define
class TraceUnpack in patch 2 and use it in patch 1.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-04-21 7:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 7:05 [PATCH v2 1/3] upstream source tracing: base process alberto
2023-04-21 7:05 ` [PATCH v2 2/3] upstream source tracing: metadata collection alberto
2023-04-21 7:11 ` [PATCH v2 3/3] upstream source tracing: tests Alberto Pianon
2023-04-21 7:28 ` Luca Ceresoli [this message]
2023-04-21 12:52 ` [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process Alberto Pianon
2023-04-21 13:50 ` Peter Kjellerstedt
2023-04-21 16:15 ` Luca Ceresoli
2023-04-23 6:50 ` Alberto Pianon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421092803.081e3cd6@booty \
--to=luca.ceresoli@bootlin.com \
--cc=alberto@pianon.eu \
--cc=bitbake-devel@lists.openembedded.org \
--cc=carlo@piana.eu \
--cc=jpewhacker@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).