From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
Cc: Alberto Pianon <alberto@pianon.eu>,
"bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process
Date: Fri, 21 Apr 2023 18:15:18 +0200 [thread overview]
Message-ID: <20230421181518.23d8a279@booty> (raw)
In-Reply-To: <DB5PR02MB102133408DCA18D8EB0999BEBEF609@DB5PR02MB10213.eurprd02.prod.outlook.com>
Hello Peter, Alberto,
On Fri, 21 Apr 2023 13:50:25 +0000
"Peter Kjellerstedt" <peter.kjellerstedt@axis.com> wrote:
> > >
> > > Also, I see this patch set is not bisectable as well as v1: you define
> > > class TraceUnpack in patch 2 and use it in patch 1.
> > >
> >
> > do you mean that:
> >
> > import TraceUnpackBase as TraceUnpack
> >
> > in patch 1 is not good, and that I should use just TraceUnpackBase
> > as a class name/alias in patch 1?
>
> My guess is that Luca missed the `import ... as` line. I believe you
> should be fine as you are.
You're right Peter, my review was too quick. Indeed Alberto's patches
are OK in that respect. Sorry for the noise.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-04-21 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 7:05 [PATCH v2 1/3] upstream source tracing: base process alberto
2023-04-21 7:05 ` [PATCH v2 2/3] upstream source tracing: metadata collection alberto
2023-04-21 7:11 ` [PATCH v2 3/3] upstream source tracing: tests Alberto Pianon
2023-04-21 7:28 ` [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process Luca Ceresoli
2023-04-21 12:52 ` Alberto Pianon
2023-04-21 13:50 ` Peter Kjellerstedt
2023-04-21 16:15 ` Luca Ceresoli [this message]
2023-04-23 6:50 ` Alberto Pianon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421181518.23d8a279@booty \
--to=luca.ceresoli@bootlin.com \
--cc=alberto@pianon.eu \
--cc=bitbake-devel@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).