From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: belouargamohamed@gmail.com
Cc: bitbake-devel@lists.openembedded.org,
f.lahoudere@technologyandstrategy.com,
e.aubineau@technologyandstrategy.com,
j.guignard@technologyandstrategy.com,
BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>
Subject: Re: [bitbake-devel] [master][PATCH] fetch2: npmsw: Don't fetch dev dependencies when they are not demanded
Date: Wed, 31 May 2023 20:47:05 +0200 [thread overview]
Message-ID: <202305311847057862e591@mail.local> (raw)
In-Reply-To: <20230530224254.43797-1-m.belouarga@technologyandstrategy.com>
Hello,
This doesn't apply on master at all, can you rebase?
Thanks!
On 31/05/2023 00:42:54+0200, belouargamohamed@gmail.com wrote:
> From: BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>
>
> Dev dependencies should not be fetched only if it is specified in the
> recipe.
>
> Signed-off-by: BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>
> ---
> lib/bb/fetch2/npmsw.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/bb/fetch2/npmsw.py b/lib/bb/fetch2/npmsw.py
> index 359192a2..d89be10c 100644
> --- a/lib/bb/fetch2/npmsw.py
> +++ b/lib/bb/fetch2/npmsw.py
> @@ -49,6 +49,8 @@ def foreach_dependencies(shrinkwrap, callback=None, dev=False):
> if package != "":
> name = package.split('node_modules/')[-1]
> package_infos = packages.get(package, {})
> + if dev == False and package_infos.get("dev", False):
> + continue
> callback(name, package_infos, package)
>
> class NpmShrinkWrap(FetchMethod):
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#14819): https://lists.openembedded.org/g/bitbake-devel/message/14819
> Mute This Topic: https://lists.openembedded.org/mt/99230772/3617179
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-05-31 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 22:42 [master][PATCH] fetch2: npmsw: Don't fetch dev dependencies when they are not demanded belouargamohamed
2023-05-31 18:47 ` Alexandre Belloni [this message]
2023-05-31 18:59 ` belouargamohamed
2023-06-01 10:22 ` [bitbake-devel] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202305311847057862e591@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=belouargamohamed@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=e.aubineau@technologyandstrategy.com \
--cc=f.lahoudere@technologyandstrategy.com \
--cc=j.guignard@technologyandstrategy.com \
--cc=m.belouarga@technologyandstrategy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).