bitbake-devel.lists.openembedded.org archive mirror
 help / color / mirror / Atom feed
From: belouargamohamed@gmail.com
To: bitbake-devel@lists.openembedded.org
Cc: BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>
Subject: [master][PATCH v2 2/3] fetch2: npmsw: Don't fetch dev dependencies when they are not demanded
Date: Sun,  4 Jun 2023 03:39:18 +0200	[thread overview]
Message-ID: <20230604013919.13904-2-m.belouarga@technologyandstrategy.com> (raw)
In-Reply-To: <20230604013919.13904-1-m.belouarga@technologyandstrategy.com>

From: BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>

Dev dependencies should not be fetched only if it is specified in the
recipe.

Signed-off-by: BELOUARGA Mohamed <m.belouarga@technologyandstrategy.com>
---
 lib/bb/fetch2/npmsw.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/bb/fetch2/npmsw.py b/lib/bb/fetch2/npmsw.py
index 359192a29e..d89be10caf 100644
--- a/lib/bb/fetch2/npmsw.py
+++ b/lib/bb/fetch2/npmsw.py
@@ -49,6 +49,8 @@ def foreach_dependencies(shrinkwrap, callback=None, dev=False):
         if package != "":
             name = package.split('node_modules/')[-1]
             package_infos = packages.get(package, {})
+            if dev == False and package_infos.get("dev", False):
+                continue
             callback(name, package_infos, package)
 
 class NpmShrinkWrap(FetchMethod):
-- 
2.25.1



  reply	other threads:[~2023-06-04  1:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04  1:39 [master][PATCH v2 1/3] bitbake: fetch2: npmsw: Add support for the new format of the shrinkwrap file belouargamohamed
2023-06-04  1:39 ` belouargamohamed [this message]
2023-06-04  1:39 ` [master][PATCH v2 3/3] fetch2: npm: Remove special caracters that causes recipe tool to fail belouargamohamed
2023-06-07 12:43 ` [bitbake-devel] [master][PATCH v2 1/3] bitbake: fetch2: npmsw: Add support for the new format of the shrinkwrap file Alexandre Belloni
2023-06-07 13:05   ` belouargamohamed
2023-06-07 19:44     ` [bitbake-devel] " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230604013919.13904-2-m.belouarga@technologyandstrategy.com \
    --to=belouargamohamed@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=m.belouarga@technologyandstrategy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).