archive mirror
 help / color / mirror / Atom feed
From: Michael Opdenacker <>
Cc: ""
Subject: Re: [bitbake-devel] [PATCH] bitbake: git fetcher: use urllib quote ...
Date: Wed, 22 Mar 2023 11:40:06 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <PR0P264MB1882D9E54AD24DF72B9E65E5E9869@PR0P264MB1882.FRAP264.PROD.OUTLOOK.COM>

Hi Thilo,

Thanks for the patch!

On 22.03.23 at 09:37, Thilo C. via wrote:
> to use the path url-compatible. This needs to happen before the shell 
> quotation happens.
> Without this commit, spaces in the clone URL will be used as " " and 
> not as "%20" which will fail.
> This commit changes the " " in the URL to "%20" when it is a http or 
> https url.
> Signed-off-by: Thilo Cestonaro <>

Oops, are you sure it applies to the latest "master" branch? I tried and 
it didn't, though I don't see why...

Another issue with your patch is the commit author name, which will be 
"Thilo C. via 
<>" instead of 
"Thilo Cestonaro <>".

for details and a solution.

Don't hesitate to try to send the patch again to me privately before 
resending to the mailing list...

Thanks again

Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering

  reply	other threads:[~2023-03-22 10:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22  8:37 [PATCH] bitbake: git fetcher: use urllib quote CESTONARO Thilo
2023-03-22 10:40 ` Michael Opdenacker [this message]
2023-04-19 12:22   ` AW: [bitbake-devel] " CESTONARO Thilo
2023-03-24 10:13 ` Alexandre Belloni
2023-04-20 11:43 ` Richard Purdie
2023-05-10 13:10   ` [PATCH v2] " CESTONARO Thilo
2023-05-10 13:24     ` [bitbake-devel] " Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).