From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Christopher Larson <kergoth@gmail.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH] fetch2/git: Avoid races over mirror tarball creation
Date: Fri, 17 Sep 2021 18:00:15 +0100 [thread overview]
Message-ID: <4a85154f3adbef12e3db4e2407e0944ba18d8108.camel@linuxfoundation.org> (raw)
In-Reply-To: <CABcZANnHTKDbdBW1BauJrUURe39yovtaooJ7k_4_CCgqq_zxAA@mail.gmail.com>
On Fri, 2021-09-17 at 09:50 -0700, Christopher Larson wrote:
> This looks good, though if we're creating the temporary file in the same
> directory as the resulting file, which seems to be the case, could we not just
> os.rename() rather than calling a subprocess?
I meant to check that, I had some recollection the rename might not work if the
file already exists in the os.rename() case. I got distracted by other things
and didn't get back to it but it looks like that should be fine glancing at the
manual.
Cheers,
Richard
prev parent reply other threads:[~2021-09-17 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 14:25 [PATCH] fetch2/git: Avoid races over mirror tarball creation Richard Purdie
2021-09-17 16:50 ` [bitbake-devel] " Christopher Larson
2021-09-17 17:00 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a85154f3adbef12e3db4e2407e0944ba18d8108.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=kergoth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).