Re: [bitbake-devel] [PATCH 0/1] RFC Bug in PREMIRROR

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Wed, 2021-09-01 at 16:46 -0500, Mark Hatle wrote:
> 
> On 9/1/21 4:40 PM, Richard Purdie wrote:
> > On Wed, 2021-09-01 at 12:44 -0700, Vishal Patel wrote:
> > > I think we found a bug in the PREMIRROR system where if both a remote and local
> > > PREMIRROR is defined, as well as BB_NO_NETWORK = '1', the system will fail with
> > > 
> > > bb.fetch2.NetworkAccess: Network access disabled through BB_NO_NETWORK (or set indirectly due to use of BB_FETCH_PREMIRRORONLY)
> > > 
> > > instead of trying the next PREMIRROR which is a local file:// based one.
> > > The attached patch only adds a test case for the issue, but does not fix the problem.
> > > If anyone can point me to where to fix the problem, I can work on this.
> > 
> > Thanks for the testcase, that does at least make this easy to see.
> > 
> > Running the test, it is clear from the trace that after trying a mirror, the
> > bb.fetch2.NetworkAccess exception is fatal and stops any other url from being
> > tried. That does seem not to be what the user would want.
> > 
> > I was going to let you debug that but I did quickly try this:
> > 
> > 
> > diff --git a/bitbake/lib/bb/fetch2/__init__.py
> > b/bitbake/lib/bb/fetch2/__init__.py
> > index 914fa5c0243..65d8c38af76 100644
> > --- a/bitbake/lib/bb/fetch2/__init__.py
> > +++ b/bitbake/lib/bb/fetch2/__init__.py
> > @@ -1034,7 +1034,7 @@ def try_mirror_url(fetch, origud, ud, ld, check = False):
> >          return ud.localpath
> >  
> >      except bb.fetch2.NetworkAccess:
> > -        raise
> > +        return False
> >  
> >      except IOError as e:
> >          if e.errno in [errno.ESTALE]:
> > 
> > and found that does make your test case pass. It also doesn't regress any other
> > test that I spotted in quick testing.
> > 
> > I'm not sure if that is the correct fix, I'd need to think about it a bit more. 
> > 
> > The question is whether if you disable the networking, you want errors on
> > network access or want the accesses disabled. Some people do want to know if the
> > network is used when disabled and BB_NO_NETWORK may mean different things to
> > different people.
> 
> I thought in the past it just skipped them but stored a message or something
> about the networkaccess.. then if it couldn't find anything it THEN displayed
> the message.
> 
> roughly:
> 
> try... ohh network?  capture exception
> try next...
> try next...
> nothing found, print exception message (and since it's PREMIRROR don't fail,
> continue to regular download and then MIRROR)

It does that about general failures but network access is different. Some users
expect it to fail immediately for any access.

Cheers,

Richard