bitbake-devel.lists.openembedded.org archive mirror
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paulo Neves <paulo@myneves.com>, bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/5] tests: git-lfs: Restore _find_git_lfs
Date: Wed, 22 Feb 2023 12:01:04 +0000	[thread overview]
Message-ID: <8ef30c400c868a008d07714cb1656c7c3fa646ac.camel@linuxfoundation.org> (raw)
In-Reply-To: <20230217170009.58707-1-paulo@myneves.com>

On Fri, 2023-02-17 at 17:00 +0000, Paulo Neves wrote:
> Not restoring the mocked _find_git_lfs leads to other tests
> failing.
> 
> Signed-off-by: Paulo Neves <paulo@myneves.com>
> ---
>  lib/bb/tests/fetch.py | 40 ++++++++++++++++++++++++----------------
>  1 file changed, 24 insertions(+), 16 deletions(-)

Just for future reference, the shortlog entries for these patches needs
tweaking. For example in this case I'd have written:

tests/fetch: git-lfs restore _find_git_lfs

since that makes it clear it is the fetch test being changed.

In other changes you used both "git" and "git.py", I'd suggest just
using "git" and I'd probably use "fetch/git" to make it clear it was
the git fetcher.

I'll fix up these in the patch queue this time so no need to resend.

Cheers,

Richard



      parent reply	other threads:[~2023-02-22 12:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 17:00 [PATCH 1/5] tests: git-lfs: Restore _find_git_lfs Paulo Neves
2023-02-17 17:00 ` [PATCH 2/5] test: Add real git lfs tests and decorator Paulo Neves
2023-02-17 17:00 ` [PATCH 3/5] git: Remove is None check on _find_git_lfs Paulo Neves
2023-02-22 12:03   ` [bitbake-devel] " Richard Purdie
2023-02-17 17:01 ` [PATCH 4/5] git.py: @_contains_lfs: Removed unused variables Paulo Neves
2023-02-17 17:01 ` [PATCH 5/5] git.py Replace mkdtemp with TemporaryDirectory and avoid exception masking Paulo Neves
2023-02-22 12:01 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ef30c400c868a008d07714cb1656c7c3fa646ac.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=paulo@myneves.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).