From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D2DC433EF for ; Tue, 26 Oct 2021 22:52:26 +0000 (UTC) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by mx.groups.io with SMTP id smtpd.web09.4130.1635288744986173561 for ; Tue, 26 Oct 2021 15:52:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@konsulko.com header.s=google header.b=f/JEcqY/; spf=pass (domain: konsulko.com, ip: 209.85.222.42, mailfrom: scott.murray@konsulko.com) Received: by mail-ua1-f42.google.com with SMTP id f24so1293919uav.12 for ; Tue, 26 Oct 2021 15:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9baU40iRTpCfEosnDFbupWIzsNWUilUrDV7eUxVEAFk=; b=f/JEcqY/sUCxUq8pvZwRvJh4o4+HHqII3l3FV95/fYXk/3E4YbUgU3xvzglxN1s+fd liY3PD9+qGwEGFQZsEDJjOOfXPXTtHPVBCalAiMzEYPGqhqlFquIyHFM8ycmQYc+WH5T mkSzSkQFv9wHvPxh6lNh8bbM/8cG4HvcRIMCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9baU40iRTpCfEosnDFbupWIzsNWUilUrDV7eUxVEAFk=; b=gUSdrVapctKA0WRY2J8IcQSmXlOcoCU3aXk8z4aOPq5Y0ai1yFlm/xUWZXY1q6Kox7 R7BMv54OOv8nnkFTcblNStCUbPjJMvRuZQuDS1d0te5VGFXGuApYkYDyYxnqTgTZxKWq pfcaHYDpzfVvJAj/51+pAsRdojN4cXpygzlE1SjnnDaIv8OwxFhVMbZ4X+sP1pScQsht ZoBIzXng+ilc7PDIC4t5fURRow0gkR9jfrkYQdT3+Hz/txPU7HvAMXetxyhDAgfUQQM6 b/KGhSoh5tnZbXwkKeXtFeRLpFCwqXT26y1WJ2j1r04NHniWH9MkWQxdVYpWktRmbrAX QCRg== X-Gm-Message-State: AOAM531/DyYWainUdUxnXfQGPg8PlxCR98ZTjfy2Ts7tAgyzz8OIp+V/ S+ZQtM8fd+gxnrNweAKQ2GGOtoNXhDWeYIHvZmCOtA== X-Google-Smtp-Source: ABdhPJw2PkWa9g1RxgK+KW4NyqlD2kisxIgtmkBmuE3Ml4X2vuyq9MXzM0V2O+7IghAbot+r991zxEAfxZsqtfCUHPg= X-Received: by 2002:a67:2c95:: with SMTP id s143mr19740208vss.0.1635288744026; Tue, 26 Oct 2021 15:52:24 -0700 (PDT) MIME-Version: 1.0 References: <7aabfa2b-2019-2dfb-3ae0-3ace4c4638d@spiteful.org> <16B1B4E0DFE93958.19566@lists.openembedded.org> <8bd2e9ff001261ae11beb8794f843965088c3162.camel@linuxfoundation.org> In-Reply-To: <8bd2e9ff001261ae11beb8794f843965088c3162.camel@linuxfoundation.org> From: Scott Murray Date: Tue, 26 Oct 2021 18:52:13 -0400 Message-ID: Subject: Re: [bitbake-devel] noexec varflag behavior vs documentation? To: Richard Purdie Cc: Konrad Weihmann , bitbake-devel Content-Type: multipart/alternative; boundary="000000000000b1754e05cf49542f" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 26 Oct 2021 22:52:26 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/12838 --000000000000b1754e05cf49542f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 26, 2021 at 6:44 PM Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Tue, 2021-10-26 at 23:23 +0100, Richard Purdie via > lists.openembedded.org > wrote: > > On Tue, 2021-10-26 at 15:54 -0400, Scott Murray wrote: > > > On Tue, 26 Oct 2021, Konrad Weihmann wrote: > > > > > > > On 26.10.21 17:57, Scott Murray wrote: > > > > > As I brought up on the dev call earlier, the task noexec varflag > > > > > documentation says: > > > > > > > > > > * [noexec]: When set to =E2=80=9C1=E2=80=9D, marks the task as be= ing empty, with no > > > > > execution required. You can use the [noexec] flag to set up tasks > as > > > > > dependency placeholders, or to disable tasks defined elsewhere > that are > > > > > not needed in a particular recipe. > > > > > > > > > > (from: > > > > > > https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-ma= nual-metadata.html?highlight=3Dnoexec#variable-flags > ) > > > > > > > > > > However, as I discovered yesterday, the reality is that it being > set to > > > > > any value at all disables execution, which Richard mentioned on > the dev > > > > > call helps with performance. The question Richard asked me to > bring here > > > > > is whether the documentation should be updated, or if the behavio= r > should > > > > > be changed to match it? I do not have a strong opinion either > way, but > > > > > would like this resolved somehow to avoid others spending time > scratching > > > > > their heads like I did for a bit yesterday. > > > > > > > > As I stumbled upon the very same, I'd love to see the docu being > updated - I > > > > mean implicitly it already does that as noexec can be only > deactivated by > > > > putting no value in it - but both cases should be properly > documented IMO > > > > > > Chris mentioned to me OOB this existing Bugzilla: > > > > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=3D13808 > > > > > > I don't see the discussed deprecation warning change in master, > though, so > > > I'm guessing it got dropped. > > > > > http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=3D66f22c0bd19a81ee7c= cb49543f24a4f90fc012ba > > > > Is that code working? > > I did check and with do_compile[noexec] =3D "0" in the bash recipe, I see= : > > WARNING: /xxx/meta/recipes-extended/bash/bash_5.1.8.bb: In a future > version of BitBake, setting the 'noexec' flag to something other than '1' > will result in the flag not being set. See YP bug #13808 > > so it does appear to. > Yes, I did just try it here as well. I've been working on dunfell and missed it in master when I looked through git grep, my apologies. I guess there's still the questions of just when the deprecation takes effect and if anything should be done with respect to the documentation in the meantime (since it could IMO be argued it's incorrect ATM). Scott --000000000000b1754e05cf49542f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Oct 26, 2021 at 6:44 PM Richard Purdie <richard.purdie@linuxfoundation.org= > wrote:
On T= ue, 2021-10-26 at 23:23 +0100, Richard Purdie via lists.openembedded.or= g
wrote:
> On Tue, 2021-10-26 at 15:54 -0400, Scott Murray wrote:
> > On Tue, 26 Oct 2021, Konrad Weihmann wrote:
> >
> > > On 26.10.21 17:57, Scott Murray wrote:
> > > > As I brought up on the dev call earlier, the task noexe= c varflag
> > > > documentation says:
> > > >
> > > > * [noexec]: When set to =E2=80=9C1=E2=80=9D, marks the = task as being empty, with no
> > > > execution required. You can use the [noexec] flag to se= t up tasks as
> > > > dependency placeholders, or to disable tasks defined el= sewhere that are
> > > > not needed in a particular recipe.
> > > >
> > > > (from:
> > > > https://docs.yoctoproject.org/= bitbake/bitbake-user-manual/bitbake-user-manual-metadata.html?highlight=3Dn= oexec#variable-flags)
> > > >
> > > > However, as I discovered yesterday, the reality is that= it being set to
> > > > any value at all disables execution, which Richard ment= ioned on the dev
> > > > call helps with performance.=C2=A0 The question Richard= asked me to bring here
> > > > is whether the documentation should be updated, or if t= he behavior should
> > > > be changed to match it?=C2=A0 I do not have a strong op= inion either way, but
> > > > would like this resolved somehow to avoid others spendi= ng time scratching
> > > > their heads like I did for a bit yesterday.
> > >
> > > As I stumbled upon the very same, I'd love to see the do= cu being updated - I
> > > mean implicitly it already does that as noexec can be only d= eactivated by
> > > putting no value in it - but both cases should be properly d= ocumented IMO
> >
> > Chris mentioned to me OOB this existing Bugzilla:
> >
> > https://bugzilla.yoctoproject.org= /show_bug.cgi?id=3D13808
> >
> > I don't see the discussed deprecation warning change in maste= r, though, so
> > I'm guessing it got dropped.
>
> = http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=3D66f22c0bd19a81ee7ccb= 49543f24a4f90fc012ba
>
> Is that code working?

I did check and with do_compile[noexec] =3D "0" in the bash recip= e, I see:

WARNING: /xxx/meta/recipes-extended/bash/bash_5.1.8.bb: In a future version = of BitBake, setting the 'noexec' flag to something other than '= 1' will result in the flag not being set. See YP bug #13808

so it does appear to.

=
Yes, I did just try it here as well.=C2=A0 I've been working on d= unfell and missed it in master
when I looked thro= ugh git grep, my apologies.=C2=A0 I guess there's still the questions o= f
just when the deprecation takes effect an= d if anything should be done with respect to
the documentation in the meantime (since it could IMO be argued it's = incorrect ATM).

Scott


--000000000000b1754e05cf49542f--