From: Peter Kjellerstedt <firstname.lastname@example.org>
To: Alberto Pianon <email@example.com>,
Luca Ceresoli <firstname.lastname@example.org>
Subject: RE: [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process
Date: Fri, 21 Apr 2023 13:50:25 +0000 [thread overview]
Message-ID: <DB5PR02MB102133408DCA18D8EB0999BEBEF609@DB5PR02MB10213.eurprd02.prod.outlook.com> (raw)
> -----Original Message-----
> From: email@example.com <bitbake-
> firstname.lastname@example.org> On Behalf Of Alberto Pianon
> Sent: den 21 april 2023 14:53
> To: Luca Ceresoli <email@example.com>
> Cc: firstname.lastname@example.org
> Subject: Re: [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base
> Il 2023-04-21 09:28 Luca Ceresoli ha scritto:
> > Hello Alberto,
> > On Fri, 21 Apr 2023 09:05:23 +0200
> > "Alberto Pianon" <email@example.com> wrote:
> >> From: Alberto Pianon <firstname.lastname@example.org>
> >> License compliance, SBoM generation and CVE checking require to be
> >> able
> >> to trace each source file back to its corresponding upstream source.
> >> The
> >> current implementation of bb.fetch2 makes it difficult, especially
> >> when
> >> multiple sources are combined together.
> >> This patch provides an interface to solve the issue by implementing a
> >> process that unpacks each SRC_URI element into a temporary directory,
> >> creates an entrypoint to collect relevant provenance metadata on each
> >> source file, moves everything to the recipe rootdir, and saves
> >> metadata
> >> in a JSON file.
> >> This patch contains required modifications to fetchers' code plus a
> >> TraceUnpackBase class that implements the above described process.
> >> Data
> >> collection logic should be separately implemented by subclassing
> >> TraceUnpackBase, implementing _collect_data() and _process_data()
> >> methods.
> >> Splitting the above described solution in multiple patches aims
> >> at easing review and merge process, and also at decoupling the
> >> development of the data processing logic from the process that enables
> >> it.
> >> Signed-off-by: Alberto Pianon <email@example.com>
> > Thank you for having fixed the subject! Now I can apply your patches
> > with a clean git commit.
> > Do you think the build failures I reported on the v1 series are fixed
> > by this v2? If you think so, then I can test v2 on the autobuilders.
> No but I'm working on it. Actually, I should have found the problem:
> it's just that in some tests WORKDIR/temp is not created so I added
> a check to create it if it's not present. I'm testing it, but
> oe-selftest is taking forever in my build machine. So far, no error
> in the logs...
> > Also, I see this patch set is not bisectable as well as v1: you define
> > class TraceUnpack in patch 2 and use it in patch 1.
> do you mean that:
> import TraceUnpackBase as TraceUnpack
> in patch 1 is not good, and that I should use just TraceUnpackBase
> as a class name/alias in patch 1?
My guess is that Luca missed the `import ... as` line. I believe you
should be fine as you are. However, one thing I would point out is the
commit subjects. For changes to the fetcher, the subject should
typically start with "fetch2: " so that one can clearly see with, e.g.,
`git log --oneline` where you are making changes. If it was up to me,
I would change the subjects for the three commits to:
fetch2: Add support for upstream source tracing
fetch2: Add metadata collection for upstream source tracing
fetch2: Add tests for upstream source tracing
next prev parent reply other threads:[~2023-04-21 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 7:05 [PATCH v2 1/3] upstream source tracing: base process alberto
2023-04-21 7:05 ` [PATCH v2 2/3] upstream source tracing: metadata collection alberto
2023-04-21 7:11 ` [PATCH v2 3/3] upstream source tracing: tests Alberto Pianon
2023-04-21 7:28 ` [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process Luca Ceresoli
2023-04-21 12:52 ` Alberto Pianon
2023-04-21 13:50 ` Peter Kjellerstedt [this message]
2023-04-21 16:15 ` Luca Ceresoli
2023-04-23 6:50 ` Alberto Pianon
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).