bitbake-devel.lists.openembedded.org archive mirror
 help / color / mirror / Atom feed
* RE: [bitbake-devel] [master][mickledore][PATCH 1/2] fetch2/crate: Simplify extraction of crate names and versions from URIs
       [not found] <175A434F8636122B.26969@lists.openembedded.org>
@ 2023-05-22 23:52 ` Peter Kjellerstedt
  0 siblings, 0 replies; only message in thread
From: Peter Kjellerstedt @ 2023-05-22 23:52 UTC (permalink / raw)
  To: bitbake-devel

*ping*

Were there any problems with these two patches, or were they just missed?

//Peter

> -----Original Message-----
> From: bitbake-devel@lists.openembedded.org <bitbake-
> devel@lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> Sent: den 29 april 2023 03:23
> To: bitbake-devel@lists.openembedded.org
> Subject: [bitbake-devel] [master][mickledore][PATCH 1/2] fetch2/crate:
> Simplify extraction of crate names and versions from URIs
> 
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
> 
> @Steve Sakoman: Since this is a clean up patch, I will leave it up to
> you to decide if you want to take it for Mickledore once it makes it
> into master.
> 
>  bitbake/lib/bb/fetch2/crate.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/bitbake/lib/bb/fetch2/crate.py
> b/bitbake/lib/bb/fetch2/crate.py
> index a7021e5b36..2b8b6bc7a1 100644
> --- a/bitbake/lib/bb/fetch2/crate.py
> +++ b/bitbake/lib/bb/fetch2/crate.py
> @@ -59,11 +59,11 @@ class Crate(Wget):
>          # version is expected to be the last token
>          # but ignore possible url parameters which will be used
>          # by the top fetcher class
> -        version, _, _ = parts[len(parts) -1].partition(";")
> +        version = parts[-1].split(";")[0]
>          # second to last field is name
> -        name = parts[len(parts) - 2]
> +        name = parts[-2]
>          # host (this is to allow custom crate registries to be specified
> -        host = '/'.join(parts[2:len(parts) - 2])
> +        host = '/'.join(parts[2:-2])
> 
>          # if using upstream just fix it up nicely
>          if host == 'crates.io':


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-22 23:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <175A434F8636122B.26969@lists.openembedded.org>
2023-05-22 23:52 ` [bitbake-devel] [master][mickledore][PATCH 1/2] fetch2/crate: Simplify extraction of crate names and versions from URIs Peter Kjellerstedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).