AW: [bitbake-devel] [PATCH] bitbake: git fetcher: use urllib quote ...

[CESTONARO Thilo <thilo.cestonaro@thalesgroup.com>]

[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]

Hi Michael

Sorry for the late answer.
I'm currently trying to be able to directly send the patches via Git but our IT does not allow it.

So here is another try with Outlook. And hopefully it does not change anything, like last time. As I think it was Outlooks fault that the patch did not apply.

This time I gzipped it. Hopefully this is ok for you!

Cheers
Thilo

________________________________________
Von: Michael Opdenacker <michael.opdenacker@bootlin.com>
Gesendet: Mittwoch, 22. März 2023 11:40
An: CESTONARO Thilo
Cc: bitbake-devel@lists.openembedded.org
Betreff: Re: [bitbake-devel] [PATCH] bitbake: git fetcher: use urllib quote ...

Hi Thilo,


Thanks for the patch!


On 22.03.23 at 09:37, Thilo C. via lists.openembedded.org wrote:
> to use the path url-compatible. This needs to happen before the shell
> quotation happens.
>
> Without this commit, spaces in the clone URL will be used as " " and
> not as "%20" which will fail.
> This commit changes the " " in the URL to "%20" when it is a http or
> https url.
>
> Signed-off-by: Thilo Cestonaro <thilo.cestonaro@thalesgroup.com>


Oops, are you sure it applies to the latest "master" branch? I tried and
it didn't, though I don't see why...


Another issue with your patch is the commit author name, which will be
"Thilo C. via lists.openembedded.org
<thilo.cestonaro=thalesgroup.com@lists.openembedded.org>" instead of
"Thilo Cestonaro <thilo.cestonaro@thalesgroup.com>".


See
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity
for details and a solution.


Don't hesitate to try to send the patch again to me privately before
resending to the mailing list...


Thanks again
Cheers
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


[-- Attachment #2: 0001-bitbake-git-fetcher-use-urllib-quote.patch.gz --]
[-- Type: application/gzip, Size: 778 bytes --]