From: CESTONARO Thilo <email@example.com>
To: Michael Opdenacker <firstname.lastname@example.org>
Subject: AW: [bitbake-devel] [PATCH] bitbake: git fetcher: use urllib quote ...
Date: Wed, 19 Apr 2023 12:22:44 +0000 [thread overview]
Message-ID: <PR0P264MB188270D04F76005A7793A012E9629@PR0P264MB1882.FRAP264.PROD.OUTLOOK.COM> (raw)
[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]
Sorry for the late answer.
I'm currently trying to be able to directly send the patches via Git but our IT does not allow it.
So here is another try with Outlook. And hopefully it does not change anything, like last time. As I think it was Outlooks fault that the patch did not apply.
This time I gzipped it. Hopefully this is ok for you!
Von: Michael Opdenacker <email@example.com>
Gesendet: Mittwoch, 22. März 2023 11:40
An: CESTONARO Thilo
Betreff: Re: [bitbake-devel] [PATCH] bitbake: git fetcher: use urllib quote ...
Thanks for the patch!
On 22.03.23 at 09:37, Thilo C. via lists.openembedded.org wrote:
> to use the path url-compatible. This needs to happen before the shell
> quotation happens.
> Without this commit, spaces in the clone URL will be used as " " and
> not as "%20" which will fail.
> This commit changes the " " in the URL to "%20" when it is a http or
> https url.
> Signed-off-by: Thilo Cestonaro <firstname.lastname@example.org>
Oops, are you sure it applies to the latest "master" branch? I tried and
it didn't, though I don't see why...
Another issue with your patch is the commit author name, which will be
"Thilo C. via lists.openembedded.org
<email@example.com>" instead of
"Thilo Cestonaro <firstname.lastname@example.org>".
for details and a solution.
Don't hesitate to try to send the patch again to me privately before
resending to the mailing list...
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
[-- Attachment #2: 0001-bitbake-git-fetcher-use-urllib-quote.patch.gz --]
[-- Type: application/gzip, Size: 778 bytes --]
next prev parent reply other threads:[~2023-04-19 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 8:37 [PATCH] bitbake: git fetcher: use urllib quote CESTONARO Thilo
2023-03-22 10:40 ` [bitbake-devel] " Michael Opdenacker
2023-04-19 12:22 ` CESTONARO Thilo [this message]
2023-03-24 10:13 ` Alexandre Belloni
2023-04-20 11:43 ` Richard Purdie
2023-05-10 13:10 ` [PATCH v2] " CESTONARO Thilo
2023-05-10 13:24 ` [bitbake-devel] " Michael Opdenacker
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).