archive mirror
 help / color / mirror / Atom feed
From: Michael Opdenacker <>
Subject: Re: [bitbake-devel] [PATCH] npmsw fetcher: Avoid instantiating Fetch class if url list is empty
Date: Mon, 17 Apr 2023 11:26:22 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20230417095342.67ee03f9@booty>

Hi Svend

On 17.04.23 at 09:53, Luca Ceresoli via wrote:
> Hello Svend,
> On Sun, 16 Apr 2023 13:07:15 -0700
> wrote:
>> Recipes containing both git and npmsw sources in the SRC_URI
>> fail during fetch from the shrinkwrap. It seems that when the fetcher is
>> fetching from the shrinkwrap, the SRCREV variable has been deleted but it
>> still ends up fetching from the git source resulting in an error because
>> SRCREV is undefined. The root cause of this is that the Fetch class defaults
>> to urls from the SRC_URI when the urls parameter contains an empty list. This
>> patch will ensure that Fetch is not instantiated if the urls list is empty.
>> Signed-off-by: Svend Meyland Nicolaisen <>
> Thanks for your patch. However it does not apply using 'git am',
> because it is an HTML e-mail.
> The simplest way to send a properly formatted patch is using 'git
> send-email'.
> For more info read:

In particular, make sure you don't miss, 
because the way your e-mail is configured, you won't have a correct git 
"Author" field, which should match your "Signed-off-by" information.

Thanks in advance :)

Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering

  reply	other threads:[~2023-04-17  9:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-16 20:07 [PATCH] npmsw fetcher: Avoid instantiating Fetch class if url list is empty public
2023-04-17  7:53 ` [bitbake-devel] " Luca Ceresoli
2023-04-17  9:26   ` Michael Opdenacker [this message]
2023-04-17 21:18     ` Svend Meyland Nicolaisen
2023-04-18  8:11       ` [bitbake-devel] " Michael Opdenacker
2023-04-17 21:12 Svend Meyland Nicolaisen
2023-04-18 10:24 ` [bitbake-devel] " Luca Ceresoli
2023-04-18 20:56   ` Svend Meyland Nicolaisen
2023-04-19  7:46     ` [bitbake-devel] " Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).