From: "Anuj Mittal" <anuj.mittal@intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: [hardknott][PATCH 6/8] bitbake-worker: Improve error handling
Date: Tue, 21 Sep 2021 16:35:14 +0800 [thread overview]
Message-ID: <bba14ded214579b22e86c40691b3015e74a294d3.1632212181.git.anuj.mittal@intel.com> (raw)
In-Reply-To: <cover.1632212181.git.anuj.mittal@intel.com>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
If bitbake-worker fails, return an error code showing that. Also
make the thread cleanup code explict in a finally clause as it would
otherwise hang.
[YOCTO #14393]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 7e0af70fb53fb13f824ca954b8cc1dffee730233)
Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
---
bin/bitbake-worker | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/bin/bitbake-worker b/bin/bitbake-worker
index 7d982f90b..3ca8c1853 100755
--- a/bin/bitbake-worker
+++ b/bin/bitbake-worker
@@ -513,9 +513,11 @@ except BaseException as e:
import traceback
sys.stderr.write(traceback.format_exc())
sys.stderr.write(str(e))
-
-worker_thread_exit = True
-worker_thread.join()
+finally:
+ worker_thread_exit = True
+ worker_thread.join()
workerlog_write("exiting")
+if not normalexit:
+ sys.exit(1)
sys.exit(0)
--
2.31.1
next prev parent reply other threads:[~2021-09-21 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 8:35 [hardknott][PATCH 0/8] Review request Anuj Mittal
2021-09-21 8:35 ` [hardknott][PATCH 1/8] cookerdata: Show error for no BBLAYERS in bblayers.conf Anuj Mittal
2021-09-21 8:35 ` [hardknott][PATCH 2/8] cookerdata: Improve missing core layer error message Anuj Mittal
2021-09-21 8:35 ` [hardknott][PATCH 3/8] data_smart: Improve error display for handled exceptions Anuj Mittal
2021-09-21 8:35 ` [hardknott][PATCH 4/8] runqueue: Clean up task stats handling Anuj Mittal
2021-09-21 8:35 ` [hardknott][PATCH 5/8] cooker/process: Fix typos in exiting message Anuj Mittal
2021-09-21 8:35 ` Anuj Mittal [this message]
2021-09-21 8:35 ` [hardknott][PATCH 7/8] cookerdata: Show a readable error for invalid multiconfig name Anuj Mittal
2021-09-21 8:35 ` [hardknott][PATCH 8/8] runqueue/knotty: Improve UI handling of setscene task counting Anuj Mittal
2021-09-21 17:22 ` [bitbake-devel] [hardknott][PATCH 0/8] Review request Martin Jansa
2021-09-21 17:30 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bba14ded214579b22e86c40691b3015e74a294d3.1632212181.git.anuj.mittal@intel.com \
--to=anuj.mittal@intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).