From: Alberto Pianon <email@example.com>
Cc: Peter Kjellerstedt <firstname.lastname@example.org>,
Subject: Re: [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process
Date: Sun, 23 Apr 2023 08:50:28 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
I tested all patches, they should be OK now (hopefully). I also changed
subjects following Peter's suggestion.
I just sent them to the ML
Il 2023-04-21 18:15 Luca Ceresoli via lists.openembedded.org ha scritto:
> Hello Peter, Alberto,
> On Fri, 21 Apr 2023 13:50:25 +0000
> "Peter Kjellerstedt" <firstname.lastname@example.org> wrote:
>> > >
>> > > Also, I see this patch set is not bisectable as well as v1: you define
>> > > class TraceUnpack in patch 2 and use it in patch 1.
>> > >
>> > do you mean that:
>> > import TraceUnpackBase as TraceUnpack
>> > in patch 1 is not good, and that I should use just TraceUnpackBase
>> > as a class name/alias in patch 1?
>> My guess is that Luca missed the `import ... as` line. I believe you
>> should be fine as you are.
> You're right Peter, my review was too quick. Indeed Alberto's patches
> are OK in that respect. Sorry for the noise.
> Links: You receive all messages sent to this group.
> View/Reply Online (#14734):
> Mute This Topic: https://lists.openembedded.org/mt/98405736/1160266
> Group Owner: email@example.com
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub
prev parent reply other threads:[~2023-04-23 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 7:05 [PATCH v2 1/3] upstream source tracing: base process alberto
2023-04-21 7:05 ` [PATCH v2 2/3] upstream source tracing: metadata collection alberto
2023-04-21 7:11 ` [PATCH v2 3/3] upstream source tracing: tests Alberto Pianon
2023-04-21 7:28 ` [bitbake-devel] [PATCH v2 1/3] upstream source tracing: base process Luca Ceresoli
2023-04-21 12:52 ` Alberto Pianon
2023-04-21 13:50 ` Peter Kjellerstedt
2023-04-21 16:15 ` Luca Ceresoli
2023-04-23 6:50 ` Alberto Pianon [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).