From: Boris Kolpackov <boris@codesynthesis.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 2/2] kconfig: clean up header inclusion
Date: Mon, 2 Nov 2020 16:32:19 +0200 [thread overview]
Message-ID: <boris.20201102162336@codesynthesis.com> (raw)
In-Reply-To: <CAK7LNARRfK7LFrmJdMj4n77rb6pBYY=gXNLkfoSjk=pBJkg79w@mail.gmail.com>
Masahiro Yamada <masahiroy@kernel.org> writes:
> On Fri, Oct 30, 2020 at 12:52 AM Boris Kolpackov
> <boris@codesynthesis.com> wrote:
> >
> > - Add missing includes.
> > - Remove no longer necessary includes.
> > - Separate non-portable header includes for easier porting.
>
> I think the definition of "non-portable"
> depends on how far we expand the supported system.
>
> I guess you want to segregate <unistd.h> and <sys/mmap.h>
> because you do not have them on Windows, correct?
Correct. I have a set of patches that make kconfig portable to
Windows. I assume there is no interest in these patches here so
I will be maintaining them out of tree (but let me know if my
assumption is wrong and I will happily submit them). Splitting
the header inclusions into two blocks make these patches a bit
cleaner and more resilient to changes.
Let me know if you would like me to change the patch to (1)
clarify the non-portable part or (2) get rid of the split.
next prev parent reply other threads:[~2020-11-02 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 15:51 [PATCH 0/2] kconfig: header inclusion cleanups Boris Kolpackov
2020-10-29 15:51 ` [PATCH 1/2] kconfig: make lkc.h self-sufficient #include-wise Boris Kolpackov
2020-11-02 3:40 ` Masahiro Yamada
2020-10-29 15:51 ` [PATCH 2/2] kconfig: clean up header inclusion Boris Kolpackov
2020-11-02 4:27 ` Masahiro Yamada
2020-11-02 14:32 ` Boris Kolpackov [this message]
2020-11-23 5:19 ` Masahiro Yamada
2020-11-23 9:38 ` [PATCH v2 " Boris Kolpackov
2020-11-23 12:19 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=boris.20201102162336@codesynthesis.com \
--to=boris@codesynthesis.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.