bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: "Ian Rogers" <irogers@google.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Martin KaFai Lau" <kafai@fb.com>,
	"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@chromium.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Igor Russkikh" <irusskikh@marvell.com>,
	"Mark Starovoytov" <mstarovoitov@marvell.com>,
	"Horatiu Vultur" <horatiu.vultur@microchip.com>,
	"Antoine Tenart" <antoine.tenart@bootlin.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Nikolay Aleksandrov" <nikolay@cumulusnetworks.com>,
	"Roopa Prabhu" <roopa@cumulusnetworks.com>,
	"Jiri Pirko" <jiri@mellanox.com>,
	"Vlad Buslov" <vladbu@mellanox.com>,
	"Ido Schimmel" <idosch@mellanox.com>,
	"Alexandre Cassen" <acassen@gmail.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Subject: Re: [PATCH v2 1/2] tools/include: Update if_link.h and netlink.h
Date: Mon, 27 Sep 2021 19:03:27 +0200	[thread overview]
Message-ID: <014c2f18-cede-ccc6-6d45-ca09093a6c76@iogearbox.net> (raw)
In-Reply-To: <e126f901-f3ce-1325-b3c1-9d325bbc8249@iogearbox.net>

On 9/27/21 7:02 PM, Daniel Borkmann wrote:
> On 9/23/21 12:29 AM, Ian Rogers wrote:
>> Sync the uAPI headers so that userspace and the kernel match. These
>> changes make the tools version match the updates to the files in the
>> kernel directory that were updated by commits:
>> if_link.h:
>> 8f4c0e01789c hsr: enhance netlink socket interface to support PRP
>> 427f0c8c194b macvlan: Add nodst option to macvlan type source
>> 583be982d934 mctp: Add device handling and netlink interface
>> c7fa1d9b1fb1 net: bridge: mcast: dump ipv4 querier state
>> 2dba407f994e net: bridge: multicast: make tracked EHT hosts limit configurable
>> b6e5d27e32ef net: ethernet: rmnet: Add support for MAPv5 egress packets
>> 14452ca3b5ce net: qualcomm: rmnet: Export mux_id and flags to netlink
>> 78a3ea555713 net: remove comments on struct rtnl_link_stats
>> 0db0c34cfbc9 net: tighten the definition of interface statistics
>> 571912c69f0e net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.
>> 00e77ed8e64d rtnetlink: add IFLA_PARENT_[DEV|DEV_BUS]_NAME
>> 829eb208e80d rtnetlink: add support for protodown reason
>> netlink.h:
>> d07dcf9aadd6 netlink: add infrastructure to expose policies to userspace
>> 44f3625bc616 netlink: export policy in extended ACK
>> d409989b59ad netlink: simplify NLMSG_DATA with NLMSG_HDRLEN
>> a85cbe6159ff uapi: move constants from <linux/kernel.h> to <linux/const.h>
>> v2. Is a rebase and sync to the latest versions. A list of changes
>>      computed via diff and blame was added to the commit message as suggested
>>      in:
>> https://lore.kernel.org/lkml/20201015223119.1712121-1-irogers@google.com/
>> Signed-off-by: Ian Rogers <irogers@google.com>
> With both patches applied to bpf-next, this would break our CI:
> [...]
>    CC       bench.o
>    CC       bench_count.o
>    CC       bench_rename.o
>    CC       bench_trigger.o
>    CC       bench_ringbufs.o
>    BINARY   bench
>    BINARY   xdpxceiver
> xdpxceiver.c: In function ‘testapp_invalid_desc’:
> xdpxceiver.c:1223:41: warning: implicit declaration of function ‘ARRAY_SIZE’ [-Wimplicit-function-declaration]
>   1223 |  pkt_stream_generate_custom(test, pkts, ARRAY_SIZE(pkts));
>        |                                         ^~~~~~~~~~
> /usr/bin/ld: /tmp/ccoQONpi.o: in function `testapp_invalid_desc':
> /root/daniel/bpf/tools/testing/selftests/bpf/xdpxceiver.c:1223: undefined reference to `ARRAY_SIZE'
> collect2: error: ld returned 1 exit status
> make: *** [Makefile:166: /root/daniel/bpf/tools/testing/selftests/bpf/xdpxceiver] Error 1
> Please take a look and submit v3 of the series with the build issue fixed.

See also: https://github.com/kernel-patches/bpf/pull/1822/checks?check_run_id=3714445336


  reply	other threads:[~2021-09-27 17:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 22:29 [PATCH v2 1/2] tools/include: Update if_link.h and netlink.h Ian Rogers
2021-09-22 22:29 ` [PATCH v2 2/2] tools/include: Add rtnetlink.h, id_addr.h and neighbour.h Ian Rogers
2021-09-27 17:02 ` [PATCH v2 1/2] tools/include: Update if_link.h and netlink.h Daniel Borkmann
2021-09-27 17:03   ` Daniel Borkmann [this message]
2021-09-27 17:05     ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=014c2f18-cede-ccc6-6d45-ca09093a6c76@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=acassen@gmail.com \
    --cc=andrii@kernel.org \
    --cc=antoine.tenart@bootlin.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=horatiu.vultur@microchip.com \
    --cc=idosch@mellanox.com \
    --cc=irogers@google.com \
    --cc=irusskikh@marvell.com \
    --cc=jiri@mellanox.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mstarovoitov@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=songliubraving@fb.com \
    --cc=toke@redhat.com \
    --cc=vladbu@mellanox.com \
    --cc=yhs@fb.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).