From: Randy Dunlap <rdunlap@infradead.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>, bpf <bpf@vger.kernel.org>
Subject: Re: finding libelf
Date: Wed, 3 Feb 2021 12:36:10 -0800 [thread overview]
Message-ID: <01ffaa2e-c0fd-95a1-a60a-eb90cbf868ad@infradead.org> (raw)
In-Reply-To: <CAEf4BzYMbu6X1kpx-oVuwsdrFAF9--_M5KGfFkiZomBPsuYHng@mail.gmail.com>
On 2/3/21 12:33 PM, Andrii Nakryiko wrote:
> On Wed, Feb 3, 2021 at 12:15 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 2/3/21 12:12 PM, Andrii Nakryiko wrote:
>>> On Wed, Feb 3, 2021 at 12:09 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>>
>>>> On 2/3/21 11:39 AM, Andrii Nakryiko wrote:
>>>>> On Wed, Feb 3, 2021 at 9:22 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>>>>
>>>>>> On 2/3/21 2:57 AM, Toke Høiland-Jørgensen wrote:
>>>>>>> Randy Dunlap <rdunlap@infradead.org> writes:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I see this sometimes when building a kernel: (on x86_64,
>>>>>>>> with today's linux-next 20210202):
>>>>>>>>
>>>>>>>>
>>>>>>>> CONFIG_CGROUP_BPF=y
>>>>>>>> CONFIG_BPF=y
>>>>>>>> CONFIG_BPF_SYSCALL=y
>>>>>>>> CONFIG_ARCH_WANT_DEFAULT_BPF_JIT=y
>>>>>>>> CONFIG_BPF_PRELOAD=y
>>>>>>>> CONFIG_BPF_PRELOAD_UMD=m
>>>>>>>> CONFIG_HAVE_EBPF_JIT=y
>>>>>>>>
>>>>>>>>
>>>>>>>> Auto-detecting system features:
>>>>>>>> ... libelf: [ [31mOFF[m ]
>>>>>>>> ... zlib: [ [31mOFF[m ]
>>>>>>>> ... bpf: [ [31mOFF[m ]
>>>>>>>>
>>>>>>>> No libelf found
>>>>>>>> make[5]: [Makefile:287: elfdep] Error 1 (ignored)
>>>>>>>> No zlib found
>>>>>>>> make[5]: [Makefile:290: zdep] Error 1 (ignored)
>>>>>>>> BPF API too old
>>>>>>>> make[5]: [Makefile:293: bpfdep] Error 1 (ignored)
>>>>>>>>
>>>>>>>>
>>>>>>>> but pkg-config tells me:
>>>>>>>>
>>>>>>>> $ pkg-config --modversion libelf
>>>>>>>> 0.168
>>>>>>>> $ pkg-config --libs libelf
>>>>>>>> -lelf
>>>>>>>>
>>>>>>>>
>>>>>>>> Any ideas?
>>>>>>>
>>>>>>> This usually happens because there's a stale cache of the feature
>>>>>>> detection tests lying around somewhere. Look for a 'feature' directory
>>>>>>> in whatever subdir you got that error. Just removing the feature
>>>>>>> directory usually fixes this; I've fixed a couple of places where this
>>>>>>> is not picked up by 'make clean' (see, e.g., 9d9aae53b96d ("bpf/preload:
>>>>>>> Make sure Makefile cleans up after itself, and add .gitignore")) but I
>>>>>>> wouldn't be surprised if there are still some that are broken.
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Thanks for replying.
>>>>>>
>>>>>> I removed the feature subdir and still got this build error, so I
>>>>>> removed everything in BUILDDIR/kernel/bpf/preload and rebuilt --
>>>>>> and still got the same libelf build error.
>>>>>
>>>>> I hate the complexity of feature detection framework to the point that
>>>>> I'm willing to rip it out from libbpf's Makefile completely. I just
>>>>> spent an hour trying to understand what's going on in a very similar
>>>>> situation. Extremely frustrating.
>>>>>
>>>>> In your case, it might be feature detection triggered from
>>>>> resolve_btfids, so try removing
>>>>> $(OUTPUT)/tools/bpf/resolve_btfids/{feature/,FEATURE-DUMP.libbpf}.
>>>>>
>>>>> It seems like we don't do proper cleanup in resolve_btfids (it should
>>>>> probably call libbpf's clean as well). And it's beyond me why `make -C
>>>>> tools/build/feature clean` doesn't clean up FEATURE-DUMP.<use-case>
>>>>> file as well.
>>>>
>>>>
>>>> I don't think it's related to improper cleanup or old files/dirs
>>>> laying around. I say that because I did a full build in a new output dir.
>>>> and it still failed in the same way.
>>>
>>> If you cd tools/lib/bpf and run make there, does it detect those libraries?
>>
>> Yes:
>>
>> Auto-detecting system features:
>> ... libelf: [ on ]
>> ... zlib: [ on ]
>> ... bpf: [ on ]
>>
>>
>
> Sounds exactly like my case. I removed
> $(O)/tools/bpf/resolve_btfids/{feature/,FEATURE-DUMP.libbpf} and it
> started working.
I already tried that with no success.
I suppose that it could be related to how I do builds:
make ARCH=x86_64 O=subdir -j4 all
so subdir is a relative path, not an absolute path.
--
~Randy
next prev parent reply other threads:[~2021-02-03 20:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 3:50 finding libelf Randy Dunlap
2021-02-03 10:57 ` Toke Høiland-Jørgensen
2021-02-03 17:20 ` Randy Dunlap
2021-02-03 19:39 ` Andrii Nakryiko
2021-02-03 20:06 ` Andrii Nakryiko
2021-02-03 20:33 ` Jiri Olsa
2021-02-04 10:55 ` Jiri Olsa
2021-02-03 20:09 ` Randy Dunlap
2021-02-03 20:12 ` Andrii Nakryiko
2021-02-03 20:14 ` Randy Dunlap
2021-02-03 20:33 ` Andrii Nakryiko
2021-02-03 20:36 ` Randy Dunlap [this message]
2021-02-03 20:41 ` Randy Dunlap
2021-02-03 20:41 ` Andrii Nakryiko
2021-02-03 20:57 ` Randy Dunlap
2021-02-03 21:31 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ffaa2e-c0fd-95a1-a60a-eb90cbf868ad@infradead.org \
--to=rdunlap@infradead.org \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).