bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Jianlin Lv <Jianlin.Lv@arm.com>, bpf@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, ast@kernel.org, yhs@fb.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: fix segmentation fault of test_progs
Date: Tue, 11 Aug 2020 15:19:59 +0200	[thread overview]
Message-ID: <066bc6b8-8e08-e473-b454-4544e99ad7e0@iogearbox.net> (raw)
In-Reply-To: <20200810153940.125508-1-Jianlin.Lv@arm.com>

On 8/10/20 5:39 PM, Jianlin Lv wrote:
> test_progs reports the segmentation fault as below
> 
> $ sudo ./test_progs -t mmap --verbose
> test_mmap:PASS:skel_open_and_load 0 nsec
> ......
> test_mmap:PASS:adv_mmap1 0 nsec
> test_mmap:PASS:adv_mmap2 0 nsec
> test_mmap:PASS:adv_mmap3 0 nsec
> test_mmap:PASS:adv_mmap4 0 nsec
> Segmentation fault
> 
> This issue was triggered because mmap() and munmap() used inconsistent
> length parameters; mmap() creates a new mapping of 3*page_size, but the
> length parameter set in the subsequent re-map and munmap() functions is
> 4*page_size; this leads to the destruction of the process space.
> 
> To fix this issue, first create 4 pages of anonymous mapping,then do all
> the mmap() with MAP_FIXED.
> 
> Another issue is that when unmap the second page fails, the length
> parameter to delete tmp1 mappings should be 4*page_size.
> 
> Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>

Applied, thanks!

      parent reply	other threads:[~2020-08-11 13:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  6:16 [PATCH bpf-next] bpf: fix compilation warning of selftests Jianlin Lv
2020-07-31 15:00 ` Daniel Borkmann
2020-07-31 17:39 ` Andrii Nakryiko
2020-08-06 10:42 ` [PATCH bpf-next v2] " Jianlin Lv
2020-08-07  0:05   ` Alexei Starovoitov
2020-08-07 17:20 ` [PATCH bpf-next] bpf: fix segmentation fault of test_progs Jianlin Lv
2020-08-07 20:13   ` Andrii Nakryiko
2020-08-10 15:39   ` [PATCH bpf-next v2] " Jianlin Lv
2020-08-11  0:23     ` Andrii Nakryiko
2020-08-11 13:19     ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=066bc6b8-8e08-e473-b454-4544e99ad7e0@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=Jianlin.Lv@arm.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).