* Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data
[not found] <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn>
@ 2021-09-27 11:33 ` Ilya Leoshkevich
2021-09-27 15:26 ` Daniel Borkmann
0 siblings, 1 reply; 4+ messages in thread
From: Ilya Leoshkevich @ 2021-09-27 11:33 UTC (permalink / raw)
To: Tiezhu Yang, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh
Cc: Yauheni Kaliuta, netdev, bpf, linux-s390, linux-kernel, Xuefeng Li
On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
> Make sure to free jit_data through kfree() in the error path.
>
> Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
> programs")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>
> RESEND due to the following reason:
> [Can not connect to recipient's server because of unstable
> network or firewall filter. rcpt handle timeout, last handle
> info: Can not connect to vger.kernel.org]
>
> arch/s390/net/bpf_jit_comp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks!
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data
2021-09-27 11:33 ` [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data Ilya Leoshkevich
@ 2021-09-27 15:26 ` Daniel Borkmann
2021-09-27 15:58 ` Christian Borntraeger
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2021-09-27 15:26 UTC (permalink / raw)
To: Ilya Leoshkevich, Tiezhu Yang, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Alexei Starovoitov, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh
Cc: Yauheni Kaliuta, netdev, bpf, linux-s390, linux-kernel, Xuefeng Li
On 9/27/21 1:33 PM, Ilya Leoshkevich wrote:
> On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
>> Make sure to free jit_data through kfree() in the error path.
>>
>> Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
>> programs")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>
>> RESEND due to the following reason:
>> [Can not connect to recipient's server because of unstable
>> network or firewall filter. rcpt handle timeout, last handle
>> info: Can not connect to vger.kernel.org]
>>
>> arch/s390/net/bpf_jit_comp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Nice catch, thanks!
>
> Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Given s390, I presume this would be routed to Linus via Heiko/Vasily?
Thanks,
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data
2021-09-27 15:26 ` Daniel Borkmann
@ 2021-09-27 15:58 ` Christian Borntraeger
2021-09-27 16:13 ` Konstantin Ryabitsev
0 siblings, 1 reply; 4+ messages in thread
From: Christian Borntraeger @ 2021-09-27 15:58 UTC (permalink / raw)
To: Daniel Borkmann, Ilya Leoshkevich, Tiezhu Yang, Heiko Carstens,
Vasily Gorbik, Alexei Starovoitov, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Konstantin Ryabitsev
Cc: Yauheni Kaliuta, netdev, bpf, linux-s390, linux-kernel, Xuefeng Li
Am 27.09.21 um 17:26 schrieb Daniel Borkmann:
> On 9/27/21 1:33 PM, Ilya Leoshkevich wrote:
>> On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
>>> Make sure to free jit_data through kfree() in the error path.
>>>
>>> Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
>>> programs")
>>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>> ---
>>>
>>> RESEND due to the following reason:
>>> [Can not connect to recipient's server because of unstable
>>> network or firewall filter. rcpt handle timeout, last handle
>>> info: Can not connect to vger.kernel.org]
>>>
>>> arch/s390/net/bpf_jit_comp.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Nice catch, thanks!
>>
>> Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Makes sense.
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> Given s390, I presume this would be routed to Linus via Heiko/Vasily?
Yes, applied to the s390 tree.
Interestingly enough b4 cannot find the patch email on lore.
Looks like Tiezhu Yang has indeed connection issues with vger.
CC Konstantin, in case he knows something.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data
2021-09-27 15:58 ` Christian Borntraeger
@ 2021-09-27 16:13 ` Konstantin Ryabitsev
0 siblings, 0 replies; 4+ messages in thread
From: Konstantin Ryabitsev @ 2021-09-27 16:13 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Daniel Borkmann, Ilya Leoshkevich, Tiezhu Yang, Heiko Carstens,
Vasily Gorbik, Alexei Starovoitov, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Yauheni Kaliuta, netdev, bpf, linux-s390, linux-kernel,
Xuefeng Li, warthog9
On Mon, Sep 27, 2021 at 05:58:54PM +0200, Christian Borntraeger wrote:
> Interestingly enough b4 cannot find the patch email on lore.
> Looks like Tiezhu Yang has indeed connection issues with vger.
> CC Konstantin, in case he knows something.
I'm not actually in charge of vger, so I'm not able to help any further than
adding John to the cc's.
-K
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-27 16:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn>
2021-09-27 11:33 ` [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data Ilya Leoshkevich
2021-09-27 15:26 ` Daniel Borkmann
2021-09-27 15:58 ` Christian Borntraeger
2021-09-27 16:13 ` Konstantin Ryabitsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).