From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fZcT=UK=vger.kernel.org=bpf-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2125CC43218
	for <bpf@archiver.kernel.org>; Tue, 11 Jun 2019 08:54:36 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id D967A20657
	for <bpf@archiver.kernel.org>; Tue, 11 Jun 2019 08:54:35 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2404159AbfFKIyf (ORCPT <rfc822;bpf@archiver.kernel.org>);
        Tue, 11 Jun 2019 04:54:35 -0400
Received: from www62.your-server.de ([213.133.104.62]:41886 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2404119AbfFKIyf (ORCPT <rfc822;bpf@vger.kernel.org>);
        Tue, 11 Jun 2019 04:54:35 -0400
Received: from [78.46.172.3] (helo=sslproxy06.your-server.de)
        by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89_1)
        (envelope-from <daniel@iogearbox.net>)
        id 1hacY5-00010G-Es; Tue, 11 Jun 2019 10:54:33 +0200
Received: from [178.199.41.31] (helo=linux.home)
        by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89)
        (envelope-from <daniel@iogearbox.net>)
        id 1hacY5-000SqC-9a; Tue, 11 Jun 2019 10:54:33 +0200
Subject: Re: [PATCH v2 bpf-next] selftests/bpf : clean up feature/ when make
 clean
To:     Hechao Li <hechaol@fb.com>, bpf@vger.kernel.org
Cc:     netdev@vger.kernel.org, ast@kernel.org, kernel-team@fb.com
References: <20190611004307.3774913-1-hechaol@fb.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <0ef29619-baec-64c7-f64a-c7f61e2f8d5b@iogearbox.net>
Date:   Tue, 11 Jun 2019 10:54:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20190611004307.3774913-1-hechaol@fb.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: daniel@iogearbox.net
X-Virus-Scanned: Clear (ClamAV 0.100.3/25477/Tue Jun 11 10:08:28 2019)
Sender: bpf-owner@vger.kernel.org
Precedence: bulk
List-ID: <bpf.vger.kernel.org>
X-Mailing-List: bpf@vger.kernel.org

On 06/11/2019 02:43 AM, Hechao Li wrote:
> An error "implicit declaration of function 'reallocarray'" can be thrown
> with the following steps:
> 
> $ cd tools/testing/selftests/bpf
> $ make clean && make CC=<Path to GCC 4.8.5>
> $ make clean && make CC=<Path to GCC 7.x>
> 
> The cause is that the feature folder generated by GCC 4.8.5 is not
> removed, leaving feature-reallocarray being 1, which causes reallocarray
> not defined when re-compliing with GCC 7.x. This diff adds feature
> folder to EXTRA_CLEAN to avoid this problem.
> 
> v2: Rephrase the commit message.
> 
> Signed-off-by: Hechao Li <hechaol@fb.com>
> Acked-by: Andrii Nakryiko <andriin@fb.com>

Applied, thanks!