bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@fb.com>
To: Andrii Nakryiko <andriin@fb.com>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 5/6] selftests/bpf: replace test_progs and test_maps w/ general rule
Date: Wed, 16 Oct 2019 05:11:40 +0000	[thread overview]
Message-ID: <112cd221-7403-efe2-3375-bb9cc8140744@fb.com> (raw)
In-Reply-To: <20191016032949.1445888-6-andriin@fb.com>

On 10/15/19 8:29 PM, Andrii Nakryiko wrote:
> Makefile:282: warning: overriding recipe for target
> `/data/users/andriin/linux/tools/testing/selftests/bpf/test_xdp.o'
> Makefile:277: warning: ignoring old recipe for target
> `/data/users/andriin/linux/tools/testing/selftests/bpf/test_xdp.o'

I thought I can live with it, but no. It's too annoying.
Any make clean or make prints it.

Also looking at commit f96afa767baf ("selftests/bpf: enable (uncomment) 
all tests in test_libbpf.sh") that introduced this stuff...
I think it's all obsolete now.
test_libbpf* can be removed. test_progs nowadays do a lot more
than this mini-test.
Doing a test with clang native | llc -march=bpf is still useful,
but at this shape of test_libbpf it's pointless to continue doing so.
Such clang native test should be properly integrated into test_progs.
For now I suggest to remove this extra test_xdp.o recompilation
and remove test_libbpf*

  reply	other threads:[~2019-10-16  5:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16  3:29 [PATCH v2 bpf-next 0/6] Fix, clean up, and revamp selftests/bpf Makefile Andrii Nakryiko
2019-10-16  3:29 ` [PATCH v2 bpf-next 1/6] selftests/bpf: teach test_progs to cd into subdir Andrii Nakryiko
2019-10-16  3:29 ` [PATCH v2 bpf-next 2/6] selftests/bpf: make CO-RE reloc test impartial to test_progs flavor Andrii Nakryiko
2019-10-16  3:29 ` [PATCH v2 bpf-next 3/6] selftests/bpf: switch test_maps to test_progs' test.h format Andrii Nakryiko
2019-10-16  3:29 ` [PATCH v2 bpf-next 4/6] selftests/bpf: add simple per-test targets to Makefile Andrii Nakryiko
2019-10-16  3:29 ` [PATCH v2 bpf-next 5/6] selftests/bpf: replace test_progs and test_maps w/ general rule Andrii Nakryiko
2019-10-16  5:11   ` Alexei Starovoitov [this message]
2019-10-16  5:37     ` Andrii Nakryiko
2019-10-16  3:29 ` [PATCH v2 bpf-next 6/6] selftests/bpf: move test_queue_stack_map.h into progs/ where it belongs Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=112cd221-7403-efe2-3375-bb9cc8140744@fb.com \
    --to=ast@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).