From: Qian Cai <cai@lca.pw>
To: Will Deacon <will@kernel.org>, torvalds@linux-foundation.org
Cc: ast@kernel.org, akpm@linux-foundation.org, mingo@redhat.com,
peterz@infradead.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
gregkh@linuxfoundation.org, jslaby@suse.com,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
intel-gfx@lists.freedesktop.org, tytso@mit.edu, jack@suse.com,
linux-ext4@vger.kernel.org, tj@kernel.org, mark@fasheh.com,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, davem@davemloft.net,
daniel@iogearbox.net, netdev@vger.kernel.org,
bpf@vger.kernel.org, duyuyang@gmail.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, hannes@cmpxchg.org,
mhocko@kernel.org, vdavydov.dev@gmail.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
alexander.levin@microsoft.com
Subject: Re: [PATCH -next] treewide: remove unused argument in lock_release()
Date: Fri, 20 Sep 2019 08:50:36 -0400 [thread overview]
Message-ID: <1568983836.5576.194.camel@lca.pw> (raw)
In-Reply-To: <20190920093700.7nfaghxdrmubp2do@willie-the-truck>
On Fri, 2019-09-20 at 10:38 +0100, Will Deacon wrote:
> On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote:
> > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument
> > in __lock_release"), @nested is no longer used in lock_release(), so
> > remove it from all lock_release() calls and friends.
> >
> > Signed-off-by: Qian Cai <cai@lca.pw>
> > ---
>
> Although this looks fine to me at a first glance, it might be slightly
> easier to manage if you hit {spin,rwlock,seqcount,mutex,rwsem}_release()
> first with coccinelle scripts, and then hack lock_release() as a final
> patch. That way it's easy to regenerate things if needed.
I am not sure if it worth the extra efforts where I have to retest it on all
architectures, and the patch is really simple, but I can certainly do that if
you insist.
I have just confirmed the patch [1] also applied correctly to the latest
mainline, so it might be the best time just for Linus to merge it directly so it
does not introduce build errors later on?
[1]
https://lore.kernel.org/lkml/1568909380-32199-1-git-send-email-cai@lca.pw/
next prev parent reply other threads:[~2019-09-20 12:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 16:09 [PATCH -next] treewide: remove unused argument in lock_release() Qian Cai
2019-09-20 9:38 ` Will Deacon
2019-09-20 12:50 ` Qian Cai [this message]
2019-09-20 13:49 ` Will Deacon
2019-09-30 7:29 ` Peter Zijlstra
2019-10-01 12:46 ` Qian Cai
2019-10-08 16:33 ` Daniel Vetter
2019-10-08 19:18 ` Peter Zijlstra
2019-10-09 1:14 ` Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568983836.5576.194.camel@lca.pw \
--to=cai@lca.pw \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.levin@microsoft.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@ffwll.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=duyuyang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jack@suse.com \
--cc=jlbec@evilplan.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=jslaby@suse.com \
--cc=juri.lelli@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark@fasheh.com \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=peterz@infradead.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vdavydov.dev@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).