From: John Fastabend <john.fastabend@gmail.com>
To: yhs@fb.com, andrii.nakryiko@gmail.com, ast@kernel.org,
daniel@iogearbox.net
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
john.fastabend@gmail.com, jakub@cloudflare.com,
lmb@cloudflare.com
Subject: [bpf-next PATCH v4 0/5] bpf: Add sk_msg and networking helpers
Date: Thu, 21 May 2020 21:23:36 -0700 [thread overview]
Message-ID: <159012108670.14791.18091717338621259928.stgit@john-Precision-5820-Tower> (raw)
This series adds helpers for sk_msg program type and based on feedback
from v1 adds *_task_* helpers and probe_* helpers to all networking
programs with perfmon_capable() capabilities.
The list of helpers breaks down as follows,
Networking with perfmon_capable() guard (patch2):
BPF_FUNC_get_current_task
BPF_FUNC_current_task_under_cgroup
BPF_FUNC_probe_read_user
BPF_FUNC_probe_read_kernel
BPF_FUNC_probe_read_user_str
BPF_FUNC_probe_read_kernel_str
Added to sk_msg program types (patch1,3):
BPF_FUNC_perf_event_output
BPF_FUNC_get_current_uid_gid
BPF_FUNC_get_current_pid_tgid
BPF_FUNC_get_current_cgroup_id
BPF_FUNC_get_current_ancestor_cgroup_id
BPF_FUNC_get_cgroup_classid
BPF_FUNC_sk_storage_get
BPF_FUNC_sk_storage_delete
For testing we create two tests. One specifically for the sk_msg
program types which encodes a common pattern we use to test verifier
logic now and as the verifier evolves.
Next we have skb classifier test. This uses the test run infra to
run a test which uses the get_current_task, current_task_under_cgroup,
probe_read_kernel, and probe_reak_kernel_str.
Note we dropped the old probe_read variants probe_read() and
probe_read_str() in v2.
v3->v4:
patch4, remove macros and put code inline, add test cleanup, remove
version in bpf program.
patch5, use ctask returned from task_under_cgroup so that we avoid
any potential compiler warnings, add test cleanup, use BTF style
maps.
v2->v3:
Pulled header update of tools sk_msg_md{} structure into patch3 for
easier review. ACKs from Yonghong pushed into v3
v1->v2:
Pulled generic helpers *current_task* and probe_* into the
base func helper so they can be used more widely in networking scope.
BPF capabilities patch is now in bpf-next so use perfmon_capable() check
instead of CAP_SYS_ADMIN.
Drop old probe helpers, probe_read() and probe_read_str()
Added tests.
Thanks to Daniel, Yonghong, and Andrii for review and feedback.
---
John Fastabend (5):
bpf: sk_msg add some generic helpers that may be useful from sk_msg
bpf: extend bpf_base_func_proto helpers with probe_* and *current_task*
bpf: sk_msg add get socket storage helpers
bpf: selftests, add sk_msg helpers load and attach test
bpf: selftests, test probe_* helpers from SCHED_CLS
.../testing/selftests/bpf/prog_tests/skb_helpers.c | 30 +++++++++++++
.../selftests/bpf/prog_tests/sockmap_basic.c | 35 +++++++++++++++
.../testing/selftests/bpf/progs/test_skb_helpers.c | 33 ++++++++++++++
.../selftests/bpf/progs/test_skmsg_load_helpers.c | 47 ++++++++++++++++++++
4 files changed, 145 insertions(+)
create mode 100644 tools/testing/selftests/bpf/prog_tests/skb_helpers.c
create mode 100644 tools/testing/selftests/bpf/progs/test_skb_helpers.c
create mode 100644 tools/testing/selftests/bpf/progs/test_skmsg_load_helpers.c
--
Signature
next reply other threads:[~2020-05-22 4:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 4:23 John Fastabend [this message]
2020-05-22 4:24 ` [bpf-next PATCH v4 1/5] bpf: sk_msg add some generic helpers that may be useful from sk_msg John Fastabend
2020-05-22 4:24 ` [bpf-next PATCH v4 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task* John Fastabend
2020-05-22 23:03 ` Daniel Borkmann
2020-05-23 16:29 ` John Fastabend
2020-05-22 4:24 ` [bpf-next PATCH v4 3/5] bpf: sk_msg add get socket storage helpers John Fastabend
2020-05-22 4:25 ` [bpf-next PATCH v4 4/5] bpf: selftests, add sk_msg helpers load and attach test John Fastabend
2020-05-22 9:20 ` Jakub Sitnicki
2020-05-22 4:25 ` [bpf-next PATCH v4 5/5] bpf: selftests, test probe_* helpers from SCHED_CLS John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159012108670.14791.18091717338621259928.stgit@john-Precision-5820-Tower \
--to=john.fastabend@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).