From: patchwork-bot+netdevbpf@kernel.org
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: davem@davemloft.net, daniel@iogearbox.net,
john.fastabend@gmail.com, netdev@vger.kernel.org,
bpf@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH bpf-next] bpf: Fix register equivalence tracking.
Date: Thu, 15 Oct 2020 14:10:03 +0000 [thread overview]
Message-ID: <160277100353.23379.5919005498443504637.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20201014175608.1416-1-alexei.starovoitov@gmail.com>
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Wed, 14 Oct 2020 10:56:08 -0700 you wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> The 64-bit JEQ/JNE handling in reg_set_min_max() was clearing reg->id in either
> true or false branch. In the case 'if (reg->id)' check was done on the other
> branch the counter part register would have reg->id == 0 when called into
> find_equal_scalars(). In such case the helper would incorrectly identify other
> registers with id == 0 as equivalent and propagate the state incorrectly.
> Fix it by preserving ID across reg_set_min_max().
> In other words any kind of comparison operator on the scalar register
> should preserve its ID to recognize:
> r1 = r2
> if (r1 == 20) {
> #1 here both r1 and r2 == 20
> } else if (r2 < 20) {
> #2 here both r1 and r2 < 20
> }
>
> [...]
Here is the summary with links:
- [bpf-next] bpf: Fix register equivalence tracking.
https://git.kernel.org/bpf/bpf-next/c/e688c3db7ca6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2020-10-15 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 17:56 [PATCH bpf-next] bpf: Fix register equivalence tracking Alexei Starovoitov
2020-10-14 23:09 ` Andrii Nakryiko
2020-10-15 4:04 ` John Fastabend
2020-10-15 4:19 ` Alexei Starovoitov
2020-10-15 4:27 ` John Fastabend
2020-10-15 4:33 ` Alexei Starovoitov
2020-10-15 5:23 ` John Fastabend
2020-10-15 5:46 ` Yonghong Song
2020-10-15 5:48 ` Yonghong Song
2020-10-15 14:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160277100353.23379.5919005498443504637.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).