From: Alexander Duyck <alexander.duyck@gmail.com>
To: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org, daniel@iogearbox.net, kafai@fb.com,
kernel-team@fb.com, edumazet@google.com, brakmo@fb.com,
alexanderduyck@fb.com, weiwan@google.com
Subject: [net PATCH 0/2] tcp: Address issues with ECT0 not being set in DCTCP packets
Date: Thu, 19 Nov 2020 13:23:43 -0800 [thread overview]
Message-ID: <160582070138.66684.11785214534154816097.stgit@localhost.localdomain> (raw)
This patch set is meant to address issues seen with SYN/ACK packets not
containing the ECT0 bit when DCTCP is configured as the congestion control
algorithm for a TCP socket.
A simple test using "tcpdump" and "test_progs -t bpf_tcp_ca" makes the
issue obvious. Looking at the packets will result in the SYN/ACK packet
with an ECT0 bit that does not match the other packets for the flow when
the congestion control agorithm is switch from the default. So for example
going from non-DCTCP to a DCTCP congestion control algorithm we will see
the SYN/ACK IPV6 header will not have ECT0 set while the other packets in
the flow will. Likewise if we switch from a default of DCTCP to cubic we
will see the ECT0 bit set in the SYN/ACK while the other packets in the
flow will not.
---
Alexander Duyck (2):
tcp: Allow full IP tos/IPv6 tclass to be reflected in L3 header
tcp: Set INET_ECN_xmit configuration in tcp_reinit_congestion_control
net/ipv4/tcp_cong.c | 5 +++++
1 file changed, 5 insertions(+)
--
next reply other threads:[~2020-11-19 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 21:23 Alexander Duyck [this message]
2020-11-19 21:23 ` [net PATCH 1/2] tcp: Allow full IP tos/IPv6 tclass to be reflected in L3 header Alexander Duyck
2020-11-19 23:09 ` Wei Wang
2020-11-19 21:23 ` [net PATCH 2/2] tcp: Set INET_ECN_xmit configuration in tcp_reinit_congestion_control Alexander Duyck
2020-11-21 2:22 ` [net PATCH 0/2] tcp: Address issues with ECT0 not being set in DCTCP packets Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160582070138.66684.11785214534154816097.stgit@localhost.localdomain \
--to=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=bpf@vger.kernel.org \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).