From: Jesper Dangaard Brouer <brouer@redhat.com> To: bpf@vger.kernel.org Cc: Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org, Daniel Borkmann <borkmann@iogearbox.net>, Alexei Starovoitov <alexei.starovoitov@gmail.com>, maze@google.com, lmb@cloudflare.com, shaun@tigera.io, Lorenzo Bianconi <lorenzo@kernel.org>, marek@cloudflare.com, John Fastabend <john.fastabend@gmail.com>, Jakub Kicinski <kuba@kernel.org>, eyal.birger@gmail.com, colrack@gmail.com Subject: [PATCH bpf-next V16 6/7] selftests/bpf: use bpf_check_mtu in selftest test_cls_redirect Date: Tue, 09 Feb 2021 14:38:34 +0100 [thread overview] Message-ID: <161287791481.790810.4444271170546646080.stgit@firesoul> (raw) In-Reply-To: <161287779408.790810.15631860742170694244.stgit@firesoul> This demonstrate how bpf_check_mtu() helper can easily be used together with bpf_skb_adjust_room() helper, prior to doing size adjustment, as delta argument is already setup. Hint: This specific test can be selected like this: ./test_progs -t cls_redirect Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Acked-by: John Fastabend <john.fastabend@gmail.com> --- .../selftests/bpf/progs/test_cls_redirect.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c index c9f8464996ea..3c1e042962e6 100644 --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c @@ -70,6 +70,7 @@ typedef struct { uint64_t errors_total_encap_adjust_failed; uint64_t errors_total_encap_buffer_too_small; uint64_t errors_total_redirect_loop; + uint64_t errors_total_encap_mtu_violate; } metrics_t; typedef enum { @@ -407,6 +408,7 @@ static INLINING ret_t forward_with_gre(struct __sk_buff *skb, encap_headers_t *e payload_off - sizeof(struct ethhdr) - sizeof(struct iphdr); int32_t delta = sizeof(struct gre_base_hdr) - encap_overhead; uint16_t proto = ETH_P_IP; + uint32_t mtu_len = 0; /* Loop protection: the inner packet's TTL is decremented as a safeguard * against any forwarding loop. As the only interesting field is the TTL @@ -479,6 +481,11 @@ static INLINING ret_t forward_with_gre(struct __sk_buff *skb, encap_headers_t *e } } + if (bpf_check_mtu(skb, skb->ifindex, &mtu_len, delta, 0)) { + metrics->errors_total_encap_mtu_violate++; + return TC_ACT_SHOT; + } + if (bpf_skb_adjust_room(skb, delta, BPF_ADJ_ROOM_NET, BPF_F_ADJ_ROOM_FIXED_GSO | BPF_F_ADJ_ROOM_NO_CSUM_RESET) ||
next prev parent reply other threads:[~2021-02-09 13:42 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-09 13:38 [PATCH bpf-next V16 0/7] bpf: New approach for BPF MTU handling Jesper Dangaard Brouer 2021-02-09 13:38 ` [PATCH bpf-next V16 1/7] bpf: Remove MTU check in __bpf_skb_max_len Jesper Dangaard Brouer 2021-02-09 13:38 ` [PATCH bpf-next V16 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx Jesper Dangaard Brouer 2021-02-09 13:38 ` [PATCH bpf-next V16 3/7] bpf: bpf_fib_lookup return MTU value as output when looked up Jesper Dangaard Brouer 2021-02-09 13:38 ` [PATCH bpf-next V16 4/7] bpf: add BPF-helper for MTU checking Jesper Dangaard Brouer 2021-02-09 13:38 ` [PATCH bpf-next V16 5/7] bpf: drop MTU check when doing TC-BPF redirect to ingress Jesper Dangaard Brouer 2021-02-09 13:38 ` Jesper Dangaard Brouer [this message] 2021-02-09 13:38 ` [PATCH bpf-next V16 7/7] selftests/bpf: tests using bpf_check_mtu BPF-helper Jesper Dangaard Brouer 2021-02-13 0:20 ` [PATCH bpf-next V16 0/7] bpf: New approach for BPF MTU handling patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=161287791481.790810.4444271170546646080.stgit@firesoul \ --to=brouer@redhat.com \ --cc=alexei.starovoitov@gmail.com \ --cc=borkmann@iogearbox.net \ --cc=bpf@vger.kernel.org \ --cc=colrack@gmail.com \ --cc=eyal.birger@gmail.com \ --cc=john.fastabend@gmail.com \ --cc=kuba@kernel.org \ --cc=lmb@cloudflare.com \ --cc=lorenzo@kernel.org \ --cc=marek@cloudflare.com \ --cc=maze@google.com \ --cc=netdev@vger.kernel.org \ --cc=shaun@tigera.io \ --subject='Re: [PATCH bpf-next V16 6/7] selftests/bpf: use bpf_check_mtu in selftest test_cls_redirect' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).