From: John Fastabend <john.fastabend@gmail.com>
To: john.fastabend@gmail.com, andrii@kernel.org,
daniel@iogearbox.net, ast@fb.com
Cc: xiyou.wangcong@gmail.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, lmb@cloudflare.com
Subject: [bpf PATCH 0/2] bpf, sockmap fixes
Date: Wed, 24 Mar 2021 13:59:10 -0700 [thread overview]
Message-ID: <161661943080.28508.5809575518293376322.stgit@john-Precision-5820-Tower> (raw)
This addresses an issue found while reviewing latest round of sock
map patches and an issue reported from CI via Andrii.
The CI discovered issue was introduced by over correcting our
previously broken memory accounting. After the fix, "bpf, sockmap:
Avoid returning unneeded EAGAIN when redirecting to self" we fixed
a dropped packet and a missing fwd_alloc calculations, but pushed
it too far back into the packet pipeline creating an issue in the
unlikely case socket tear down happens with an enqueued skb. See
patch for details.
Tested with usual suspects: test_sockmap, test_maps, test_progs
and test_progs-no_alu32.
---
John Fastabend (2):
bpf, sockmap: fix sk->prot unhash op reset
bpf, sockmap: fix incorrect fwd_alloc accounting
include/linux/skmsg.h | 1 -
net/core/skmsg.c | 13 ++++++-------
net/tls/tls_main.c | 6 ++++++
3 files changed, 12 insertions(+), 8 deletions(-)
--
Signature
next reply other threads:[~2021-03-24 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 20:59 John Fastabend [this message]
2021-03-24 20:59 ` [bpf PATCH 1/2] bpf, sockmap: fix sk->prot unhash op reset John Fastabend
2021-03-25 0:11 ` Cong Wang
2021-03-25 2:28 ` John Fastabend
2021-03-25 18:57 ` Cong Wang
2021-03-26 0:57 ` John Fastabend
2021-03-24 20:59 ` [bpf PATCH 2/2] bpf, sockmap: fix incorrect fwd_alloc accounting John Fastabend
2021-03-25 0:44 ` Cong Wang
2021-03-25 2:46 ` John Fastabend
2021-03-25 19:27 ` Cong Wang
2021-03-26 0:58 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161661943080.28508.5809575518293376322.stgit@john-Precision-5820-Tower \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).