From: Daniel Borkmann <email@example.com> To: Andrii Nakryiko <firstname.lastname@example.org>, John Fastabend <email@example.com> Cc: Yonghong Song <firstname.lastname@example.org>, Alexei Starovoitov <email@example.com>, Networking <firstname.lastname@example.org>, bpf <email@example.com> Subject: Re: [bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg Date: Wed, 27 May 2020 01:12:09 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAEf4Bzb7e=dpv7hP4SfLARpkDw1uTAeASRHEp9gBuK1Od=sqaA@mail.gmail.com> On 5/26/20 11:29 PM, Andrii Nakryiko wrote: > On Tue, May 26, 2020 at 1:51 PM John Fastabend <email@example.com> wrote: >> >> Andrii Nakryiko wrote: >>> On Mon, May 25, 2020 at 3:57 PM John Fastabend <firstname.lastname@example.org> wrote: >>>> >>>> Daniel Borkmann wrote: >>>>> On 5/24/20 6:50 PM, John Fastabend wrote: >>>>>> Add these generic helpers that may be useful to use from sk_msg programs. >>>>>> The helpers do not depend on ctx so we can simply add them here, >>>>>> >>>>>> BPF_FUNC_perf_event_output >>>>>> BPF_FUNC_get_current_uid_gid >>>>>> BPF_FUNC_get_current_pid_tgid >>>>>> BPF_FUNC_get_current_comm >>>>> >>>>> Hmm, added helpers below are what you list here except get_current_comm. >>>>> Was this forgotten to be added here? >>>> >>>> Forgot to update commit messages. I dropped it because it wasn't clear to >>>> me it was very useful or how I would use it from this context. I figure we >>>> can add it later if its needed. >>> >>> But it's also not harmful in any way and is in a similar group as >>> get_current_pid_tgid. So let's add it sooner rather than later. There >>> is no cost in allowing this, right? >>> >> >> It shouldn't cost anything only thing is I have code that runs the other >> three that has been deployed, at least into a dev environment, so I know >> its useful and works. >> >> How about we push it as a follow up? I can add it and do some cleanups >> on the CHECK_FAILs tonight. > > Sure, no worries, works for me. Ok, applied then, thanks!
next prev parent reply other threads:[~2020-05-26 23:12 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-24 16:50 [bpf-next PATCH v5 0/5] bpf: Add sk_msg and networking helpers John Fastabend 2020-05-24 16:50 ` [bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg John Fastabend 2020-05-25 21:51 ` Daniel Borkmann 2020-05-25 22:57 ` John Fastabend 2020-05-26 18:33 ` Andrii Nakryiko 2020-05-26 20:51 ` John Fastabend 2020-05-26 21:29 ` Andrii Nakryiko 2020-05-26 23:12 ` Daniel Borkmann [this message] 2020-05-24 16:50 ` [bpf-next PATCH v5 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task* John Fastabend 2020-05-25 21:52 ` Daniel Borkmann 2020-05-25 22:58 ` John Fastabend 2020-05-24 16:51 ` [bpf-next PATCH v5 3/5] bpf, sk_msg: add get socket storage helpers John Fastabend 2020-05-24 16:51 ` [bpf-next PATCH v5 4/5] bpf, selftests: add sk_msg helpers load and attach test John Fastabend 2020-05-26 18:07 ` Andrii Nakryiko 2020-05-24 16:51 ` [bpf-next PATCH v5 5/5] bpf, selftests: test probe_* helpers from SCHED_CLS John Fastabend 2020-05-26 18:09 ` Andrii Nakryiko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).