bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests: bpf: add missing object file to TEST_FILES
@ 2019-11-11 16:17 Anders Roxell
  2019-11-11 21:36 ` Daniel Borkmann
  0 siblings, 1 reply; 2+ messages in thread
From: Anders Roxell @ 2019-11-11 16:17 UTC (permalink / raw)
  To: ast, daniel, davem
  Cc: netdev, bpf, linux-kselftest, linux-kernel, shuah,
	songliubraving, simon.horman, Anders Roxell

When installing kselftests to its own directory and run the
test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be
found. Same with the test_tc_edt.sh test it will complain that
test_tc_edt.o can't be found.

$ ./test_lwt_ip_encap.sh
starting egress IPv4 encap test
Error opening object test_lwt_ip_encap.o: No such file or directory
Object hashing failed!
Cannot initialize ELF context!
Failed to parse eBPF program: Invalid argument

Rework to add test_lwt_ip_encap.o and test_tc_edt.o to TEST_FILES so the
object file gets installed when installing kselftest.

Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Acked-by: Song Liu <songliubraving@fb.com>
---
 tools/testing/selftests/bpf/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index b334a6db15c1..b03dc2298fea 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -38,7 +38,8 @@ TEST_GEN_PROGS += test_progs-bpf_gcc
 endif
 
 TEST_GEN_FILES =
-TEST_FILES =
+TEST_FILES = test_lwt_ip_encap.o \
+	test_tc_edt.o
 
 # Order correspond to 'make run_tests' order
 TEST_PROGS := test_kmod.sh \
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests: bpf: add missing object file to TEST_FILES
  2019-11-11 16:17 [PATCH] selftests: bpf: add missing object file to TEST_FILES Anders Roxell
@ 2019-11-11 21:36 ` Daniel Borkmann
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2019-11-11 21:36 UTC (permalink / raw)
  To: Anders Roxell, ast, davem
  Cc: netdev, bpf, linux-kselftest, linux-kernel, shuah,
	songliubraving, simon.horman

On 11/11/19 5:17 PM, Anders Roxell wrote:
> When installing kselftests to its own directory and run the
> test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be
> found. Same with the test_tc_edt.sh test it will complain that
> test_tc_edt.o can't be found.
> 
> $ ./test_lwt_ip_encap.sh
> starting egress IPv4 encap test
> Error opening object test_lwt_ip_encap.o: No such file or directory
> Object hashing failed!
> Cannot initialize ELF context!
> Failed to parse eBPF program: Invalid argument
> 
> Rework to add test_lwt_ip_encap.o and test_tc_edt.o to TEST_FILES so the
> object file gets installed when installing kselftest.
> 
> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> Acked-by: Song Liu <songliubraving@fb.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-11 21:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 16:17 [PATCH] selftests: bpf: add missing object file to TEST_FILES Anders Roxell
2019-11-11 21:36 ` Daniel Borkmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).