BPF Archive on lore.kernel.org
 help / color / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Song Liu <songliubraving@fb.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, Kernel Team <Kernel-team@fb.com>,
	Alexei Starovoitov <ast@kernel.org>,
	"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
	"kpsingh@chromium.org" <kpsingh@chromium.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h
Date: Thu, 15 Oct 2020 21:02:09 +0200
Message-ID: <1bc18cef-0a73-7a8e-0293-483f9775be26@iogearbox.net> (raw)
In-Reply-To: <5A67779B-B40B-46D4-8863-A804E20FD43C@fb.com>

On 10/15/20 7:50 AM, Song Liu wrote:
>> On Oct 14, 2020, at 9:29 PM, Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>> On Tue, Oct 13, 2020 at 09:36:38PM -0700, Song Liu wrote:
>>> Fix the following error when compiling selftests/bpf
>>>
>>> progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as different kind of symbol
>>>
>>> pids_cgrp_id is used in cgroup code, and included in vmlinux.h. Fix the
>>> error by renaming pids_cgrp_id as pids_cgroup_id.
>>>
>>> Fixes: 03d4d13fab3f ("selftests/bpf: Add profiler test")
>>> Signed-off-by: Song Liu <songliubraving@fb.com>
>>> ---
>>> tools/testing/selftests/bpf/progs/profiler.inc.h | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h
>>> index 00578311a4233..b554c1e40b9fb 100644
>>> --- a/tools/testing/selftests/bpf/progs/profiler.inc.h
>>> +++ b/tools/testing/selftests/bpf/progs/profiler.inc.h
>>> @@ -243,7 +243,7 @@ static ino_t get_inode_from_kernfs(struct kernfs_node* node)
>>> 	}
>>> }
>>>
>>> -int pids_cgrp_id = 1;
>>> +int pids_cgroup_id = 1;
>>
>> I would prefer to try one of three options that Andrii suggested.
> 
> Ah, I missed that email (because of vger lag, I guess). Just verified
> Andrii's version works.

Pls either you or Andrii respin in that case.

      reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14  4:36 Song Liu
2020-10-14 16:01 ` Song Liu
2020-10-15  4:24   ` John Fastabend
2020-10-15  4:29 ` Alexei Starovoitov
2020-10-15  5:50   ` Song Liu
2020-10-15 19:02     ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bc18cef-0a73-7a8e-0293-483f9775be26@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=Kernel-team@fb.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kpsingh@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git